refactor(components): DLT-3284 refactor props to not have native html attributes names#1204
Open
Ignacio Ropolo (iropolo) wants to merge 3 commits intonextfrom
Open
refactor(components): DLT-3284 refactor props to not have native html attributes names#1204Ignacio Ropolo (iropolo) wants to merge 3 commits intonextfrom
Ignacio Ropolo (iropolo) wants to merge 3 commits intonextfrom
Conversation
… attributes names
Contributor
|
Refactors prop and slot names across multiple components (DtNotice, DtBanner, DtToast, DtModal, DtRecipeCallbox) to avoid HTML attribute name collisions: Overall Judgement: ✅ Ready to merge — The refactoring is comprehensive and consistently applied across all affected components, their tests, and documentation. WalkthroughRenamed header-related public APIs and slots across the codebase: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Ignacio Ropolo (iropolo)
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (2)
packages/dialtone-vue/components/notice/notice.stories.js (1)
17-17: AddheaderTexttoargTypesDatato keep Storybook docs/controls in sync.Lines 17 and 135–195 move stories to
headerText, butargTypesDatadoes not define aheaderTextcontrol entry in this file.Suggested patch
export const argTypesData = { + headerText: { + control: { + type: 'text', + }, + }, // Slots icon: {As per coding guidelines, “Each component must have argTypes for all public props.”
Also applies to: 135-195
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/dialtone-vue/components/notice/notice.stories.js` at line 17, Add a headerText entry to the argTypesData object so Storybook docs/controls include the new headerText prop used by the stories; locate the argTypesData definition in this file and add a control/description/type for headerText (matching how other props are defined in argTypesData) so the stories moved to headerText (lines around 17 and 135–195) have a corresponding argType for the public prop headerText.packages/dialtone-vue/components/toast/toast.stories.js (1)
48-48:headerTextis used in story args but missing fromargTypesData.Lines 144–205 switched to
headerText, but onlyheaderIdwas updated in argTypes (Line 48). Please add an explicitheaderTextargType so controls/docs stay complete.Suggested patch
export const argTypesData = { // Slots @@ // Props + headerText: { + control: { + type: 'text', + }, + }, headerId: {As per coding guidelines, “Each component must have argTypes for all public props.”
Also applies to: 144-205
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/dialtone-vue/components/toast/toast.stories.js` at line 48, The story is missing an argType for headerText (you updated story args to use headerText in the 144–205 block but only left headerId in the argTypesData), so add an explicit argTypes entry named headerText alongside headerId in the argTypesData object for the toast component story; define it as a string control with a clear description (e.g., "Header text content" or similar) and any defaultValue/docs needed so the controls and docs reflect the public prop headerText.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/dialtone-vue/components/banner/banner.stories.js`:
- Around line 132-136: The story's public prop headerText is present in args but
missing from argTypesData, so add an argTypes entry for headerText in the
component's argTypesData (the same object that defines controls for other props)
— include a control type (e.g., 'text'), a short description, and the
appropriate table/type metadata so Storybook prop-controls stay complete and in
sync with args; update the argTypesData object near the existing arg definitions
(referencing headerText, argTypesData, and args) to include this information.
In `@packages/dialtone-vue/components/banner/banner.vue`:
- Around line 24-31: This PR renames public props/slot on the Banner component
(title → headerText, titleId → headerId, slot `#title` → `#header`) and must include
a BREAKING CHANGE footer with a clear migration map; add a single-line "BREAKING
CHANGE: ..." footer to the commit/PR description and update the
changelog/release notes with an explicit mapping (title → headerText, titleId →
headerId, `#title` → `#header`) and guidance for consumers to rename usages
accordingly so this won't ship as a silent patch.
In `@packages/dialtone-vue/components/modal/modal.stories.js`:
- Line 20: argTypesData in modal.stories.js is missing entries for the renamed
props headerText and bannerHeaderText so Storybook controls/docs won't show
them; update the argTypesData object to add prop definitions for headerText and
bannerHeaderText (with appropriate control types, descriptions, and defaultValue
entries) alongside the existing modal prop argTypes so Storybook exposes the new
public API; locate the argTypesData constant in this file and add entries for
the two props mirroring the style/fields used for the other props.
In `@packages/dialtone-vue/components/modal/modal.vue`:
- Around line 204-217: This change renames public props and must be documented
as a breaking change: add a BREAKING CHANGE footer to the commit/PR description
stating the old and new prop names (e.g. BREAKING CHANGE: prop `title` renamed
to `headerText`; prop `bannerTitle` renamed to `bannerHeaderText`) so consumers
are warned; reference the modal component props (headerText, bannerHeaderText)
in the message and include migration guidance (old → new) before merging.
In `@packages/dialtone-vue/components/toast/toast_default.story.vue`:
- Around line 12-14: This change renames Toast props titleText/titleId to
headerText/headerId and is a breaking API change; update the commit message by
adding a "BREAKING CHANGE:" footer that explains the prop rename (old prop names
titleText, titleId -> new headerText, headerId) so the release tooling will bump
major version and inform consumers; ensure the footer clearly states the
affected component (toast_default.story.vue / Toast) and the exact props that
were renamed.
In `@packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue`:
- Around line 170-173: The prop rename in callbox.vue from title to headerText
is a breaking API change; update the commit metadata to include a BREAKING
CHANGE footer (or move this change into a breaking-release branch) and document
the change in the changelog/release notes referencing the component and prop
names (Callbox component: title -> headerText) so consumers are notified; ensure
the commit message includes a precise BREAKING CHANGE description mentioning the
old prop name `title`, the new `headerText`, and any migration guidance.
---
Nitpick comments:
In `@packages/dialtone-vue/components/notice/notice.stories.js`:
- Line 17: Add a headerText entry to the argTypesData object so Storybook
docs/controls include the new headerText prop used by the stories; locate the
argTypesData definition in this file and add a control/description/type for
headerText (matching how other props are defined in argTypesData) so the stories
moved to headerText (lines around 17 and 135–195) have a corresponding argType
for the public prop headerText.
In `@packages/dialtone-vue/components/toast/toast.stories.js`:
- Line 48: The story is missing an argType for headerText (you updated story
args to use headerText in the 144–205 block but only left headerId in the
argTypesData), so add an explicit argTypes entry named headerText alongside
headerId in the argTypesData object for the toast component story; define it as
a string control with a clear description (e.g., "Header text content" or
similar) and any defaultValue/docs needed so the controls and docs reflect the
public prop headerText.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 95f8f16a-defb-4de4-ae9f-c07c615dfb76
📒 Files selected for processing (29)
packages/combinator/src/components/renderer/renderer_target.vuepackages/combinator/src/variants/variants_banner.jspackages/combinator/src/variants/variants_modal.jspackages/combinator/src/variants/variants_notice.jspackages/combinator/src/variants/variants_toast.jspackages/dialtone-vue/components/banner/banner.stories.jspackages/dialtone-vue/components/banner/banner.vuepackages/dialtone-vue/components/banner/banner_default.story.vuepackages/dialtone-vue/components/modal/modal.stories.jspackages/dialtone-vue/components/modal/modal.test.jspackages/dialtone-vue/components/modal/modal.vuepackages/dialtone-vue/components/modal/modal_default.story.vuepackages/dialtone-vue/components/notice/notice.stories.jspackages/dialtone-vue/components/notice/notice.test.jspackages/dialtone-vue/components/notice/notice.vuepackages/dialtone-vue/components/notice/notice_content.test.jspackages/dialtone-vue/components/notice/notice_content.vuepackages/dialtone-vue/components/notice/notice_default.story.vuepackages/dialtone-vue/components/toast/layouts/toast_layout_alternate.vuepackages/dialtone-vue/components/toast/layouts/toast_layout_default.vuepackages/dialtone-vue/components/toast/toast.stories.jspackages/dialtone-vue/components/toast/toast.test.jspackages/dialtone-vue/components/toast/toast.vuepackages/dialtone-vue/components/toast/toast_default.story.vuepackages/dialtone-vue/recipes/leftbar/callbox/callbox.stories.jspackages/dialtone-vue/recipes/leftbar/callbox/callbox.test.jspackages/dialtone-vue/recipes/leftbar/callbox/callbox.vuepackages/dialtone-vue/recipes/leftbar/callbox/callbox_default.story.vuepackages/dialtone-vue/recipes/leftbar/callbox/callbox_variants.story.vue
Comment on lines
+24
to
31
| :header-id="headerId" | ||
| :content-id="contentId" | ||
| :title="title" | ||
| :header-text="headerText" | ||
| > | ||
| <template #title> | ||
| <!-- @slot Slot for the title --> | ||
| <slot name="title" /> | ||
| <template #header> | ||
| <!-- @slot Slot for the header --> | ||
| <slot name="header" /> | ||
| </template> |
Contributor
There was a problem hiding this comment.
Add a BREAKING CHANGE: footer for this public API rename.
Lines 24–31 and 74–92 rename public props/slot (title/titleId/#title → headerText/headerId/#header). Please ensure the PR/commit includes an explicit BREAKING CHANGE: footer with migration mapping; otherwise this can ship as a patch and silently break consumers.
As per coding guidelines, “This is a public npm design system library … Flag any prop/event/slot removal or rename without BREAKING CHANGE footer.”
Also applies to: 74-92
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/dialtone-vue/components/banner/banner.vue` around lines 24 - 31,
This PR renames public props/slot on the Banner component (title → headerText,
titleId → headerId, slot `#title` → `#header`) and must include a BREAKING CHANGE
footer with a clear migration map; add a single-line "BREAKING CHANGE: ..."
footer to the commit/PR description and update the changelog/release notes with
an explicit mapping (title → headerText, titleId → headerId, `#title` → `#header`)
and guidance for consumers to rename usages accordingly so this won't ship as a
silent patch.
Comment on lines
+204
to
217
| * Header text to display in the modal header. | ||
| */ | ||
| title: { | ||
| headerText: { | ||
| type: String, | ||
| default: '', | ||
| }, | ||
|
|
||
| /** | ||
| * Title text to display in the modal banner. | ||
| * Header text to display in the modal banner. | ||
| */ | ||
| bannerTitle: { | ||
| bannerHeaderText: { | ||
| type: String, | ||
| default: '', | ||
| }, |
Contributor
There was a problem hiding this comment.
Mark this API rename with a BREAKING CHANGE: footer before merge.
Line 204 and Line 214 rename public modal props (title → headerText, bannerTitle → bannerHeaderText). In this public npm package, that must be explicitly marked as breaking to prevent silent patch-level consumer breakage.
As per coding guidelines, **/*: "This is a public npm library. Breaking changes without BREAKING CHANGE footer ship as patches and silently break consumers."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/dialtone-vue/components/modal/modal.vue` around lines 204 - 217,
This change renames public props and must be documented as a breaking change:
add a BREAKING CHANGE footer to the commit/PR description stating the old and
new prop names (e.g. BREAKING CHANGE: prop `title` renamed to `headerText`; prop
`bannerTitle` renamed to `bannerHeaderText`) so consumers are warned; reference
the modal component props (headerText, bannerHeaderText) in the message and
include migration guidance (old → new) before merging.
Comment on lines
+12
to
+14
| :header-text="$attrs.headerText" | ||
| :message="$attrs.message" | ||
| :title-id="$attrs.titleId" | ||
| :header-id="$attrs.headerId" |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Scan commit messages for BREAKING CHANGE footer =="
if git show-ref --verify --quiet refs/remotes/origin/next; then
BASE="$(git merge-base HEAD refs/remotes/origin/next)"
git log --format='%H%n%s%n%b%n---' "${BASE}..HEAD" | rg -n 'BREAKING CHANGE:'
else
echo "origin/next not found; scanning recent commits on current branch"
git log -n 30 --format='%H%n%s%n%b%n---' | rg -n 'BREAKING CHANGE:'
fi
echo "== Scan changeset files (if present) for breaking/major indicators =="
if [ -d .changeset ]; then
rg -n 'major|BREAKING CHANGE' .changeset
else
echo ".changeset directory not found"
fiRepository: dialpad/dialtone
Length of output: 178
🏁 Script executed:
# Check toast component prop definitions
fd -e 'toast' -type f packages/dialtone-vue/components/ | head -20Repository: dialpad/dialtone
Length of output: 230
🏁 Script executed:
# Find and inspect toast component files
find packages/dialtone-vue/components/toast -type f -name "*.js" -o -name "*.vue" | head -20Repository: dialpad/dialtone
Length of output: 687
🏁 Script executed:
# Look for the actual prop rename evidence
rg -i 'header-text|header-id|title' packages/dialtone-vue/components/toast/ -A 2 -B 2Repository: dialpad/dialtone
Length of output: 5528
🏁 Script executed:
# Check for PR description or metadata in git
git show --format=fuller HEAD | head -100Repository: dialpad/dialtone
Length of output: 4832
🏁 Script executed:
git show HEAD --format=%B --no-patchRepository: dialpad/dialtone
Length of output: 147
Add BREAKING CHANGE: footer to commit message — prop rename ships as patch and breaks consumers.
Props renamed from titleText/titleId to headerText/headerId across toast component. Without a BREAKING CHANGE: footer, this breaking change will ship as a patch version and silently break existing consumers using the old prop names.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/dialtone-vue/components/toast/toast_default.story.vue` around lines
12 - 14, This change renames Toast props titleText/titleId to
headerText/headerId and is a breaking API change; update the commit message by
adding a "BREAKING CHANGE:" footer that explains the prop rename (old prop names
titleText, titleId -> new headerText, headerId) so the release tooling will bump
major version and inform consumers; ensure the footer clearly states the
affected component (toast_default.story.vue / Toast) and the exact props that
were renamed.
Comment on lines
+170
to
173
| * Callbox header text | ||
| */ | ||
| title: { | ||
| headerText: { | ||
| type: String, |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify PR metadata and recent commit messages include a BREAKING CHANGE marker.
set -euo pipefail
echo "== PR body and commit messages containing BREAKING CHANGE =="
gh pr view 1204 --json body,commits --jq '.body, (.commits[] | .messageHeadline + "\n" + (.messageBody // ""))' \
| rg -n "BREAKING CHANGE|BREAKING-CHANGE" || true
echo "== Potential release-note/changeset files mentioning this rename =="
fd -i 'changeset|changelog|release' \
| xargs -r rg -n "BREAKING CHANGE|headerText|titleId|headerId|bannerHeaderText" || trueRepository: dialpad/dialtone
Length of output: 50374
🏁 Script executed:
#!/bin/bash
# Check the actual prop definition in callbox.vue
echo "=== Current prop definition in callbox.vue ==="
sed -n '165,180p' packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue
echo ""
echo "=== Check template usage of prop ==="
rg -A 2 -B 2 'headerText|title' packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | head -30
echo ""
echo "=== Check git log for this file (recent commits) ==="
git log --oneline -20 -- packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue
echo ""
echo "=== Check git blame for prop definition area ==="
git blame -L 170,173 packages/dialtone-vue/recipes/leftbar/callbox/callbox.vueRepository: dialpad/dialtone
Length of output: 1604
🏁 Script executed:
#!/bin/bash
echo "=== Full commit message for b56daa3e ==="
git show b56daa3e --format=fuller | head -100
echo ""
echo "=== Diff for callbox.vue in that commit ==="
git show b56daa3e -- packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | grep -A 5 -B 5 'title\|headerText' | head -60Repository: dialpad/dialtone
Length of output: 6463
🏁 Script executed:
#!/bin/bash
echo "=== Full diff for callbox.vue property changes ==="
git show b56daa3e -- packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | grep -A 10 -B 10 'title\|headerText' | head -100
echo ""
echo "=== Check if commit is in PR 1204 ==="
git log --all --oneline --grep="1204" | head -5
echo ""
echo "=== Check PR branches/tags for this commit ==="
git branch -r --contains b56daa3e | head -10
echo ""
echo "=== Check if BREAKING CHANGE appears anywhere in related PRs or recent releases ==="
rg "BREAKING CHANGE" packages/dialtone-vue/CHANGELOG.md | grep -i "header\|title\|DLT-3284" || echo "No match for header/title/DLT-3284 in BREAKING CHANGES"Repository: dialpad/dialtone
Length of output: 2825
🏁 Script executed:
#!/bin/bash
echo "=== Get the actual old version to see what prop was renamed FROM ==="
git show b56daa3e^:packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | grep -A 5 -B 5 'title\|headerText' | head -80
echo ""
echo "=== Full commit title and body to check for BREAKING CHANGE ==="
git log -1 b56daa3e --format="%B"
echo ""
echo "=== Check if DLT-3284 appears anywhere in commit messages ==="
git log --all --oneline | grep -i "3284" | head -5Repository: dialpad/dialtone
Length of output: 497
🏁 Script executed:
#!/bin/bash
echo "=== Search git history for 'title' prop in callbox.vue ==="
git log --all -p packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | grep -A 3 -B 3 "title:" | head -100
echo ""
echo "=== Check commit b56daa3e parent ==="
git log -1 b56daa3e --format="%P"
echo ""
echo "=== List all commits for callbox.vue ==="
git log --oneline packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | head -15
echo ""
echo "=== Check if callbox.vue was recently created ==="
git log --follow --oneline packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue | tail -5Repository: dialpad/dialtone
Length of output: 651
🏁 Script executed:
#!/bin/bash
echo "=== Verify if this commit is part of any published releases ==="
git tag --contains b56daa3e | head -10
echo ""
echo "=== Check recent version releases for dialtone-vue ==="
git tag -l "dialtone-vue/*" --sort=-version:refname | head -5
echo ""
echo "=== Check CHANGELOG for any mention of DLT-3284 ==="
rg "DLT-3284" packages/dialtone-vue/CHANGELOG.md
echo ""
echo "=== Check which version bump would apply to this refactor commit ==="
echo "Commit type: refactor (should be patch per semantic-release)"
echo "Has BREAKING CHANGE footer: NO"
echo "Expected release impact: PATCH (silent breaking change - a violation)"Repository: dialpad/dialtone
Length of output: 464
Add BREAKING CHANGE footer to this commit or ensure it's part of a breaking-change release.
Renaming the public prop from title to headerText is a breaking change. Commit b56daa3 (DLT-3284) is a refactor without a BREAKING CHANGE footer, which means this will ship as a patch release and silently break consumers. Per repository guidelines: "Breaking changes without BREAKING CHANGE footer ship as patches and silently break consumers."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue` around lines 170 -
173, The prop rename in callbox.vue from title to headerText is a breaking API
change; update the commit metadata to include a BREAKING CHANGE footer (or move
this change into a breaking-release branch) and document the change in the
changelog/release notes referencing the component and prop names (Callbox
component: title -> headerText) so consumers are notified; ensure the commit
message includes a precise BREAKING CHANGE description mentioning the old prop
name `title`, the new `headerText`, and any migration guidance.
Contributor
There was a problem hiding this comment.
headerText default is undefined in toast.vue but '' in notice.vue, banner.vue, and the toast layout sub-components. Probably best to just use undefined in all cases?
|
|
||
| // Props | ||
| titleId: { | ||
| headerId: { |
Contributor
There was a problem hiding this comment.
Do we need a definition for headerText also?
Contributor
Author
There was a problem hiding this comment.
Yeah added it. 👍🏼
Contributor
|
Please add either the |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/dialtone-vue/components/toast/toast.stories.js (1)
149-149: Consider updating story sample copy from “title” to “header” for API consistency.The prop name is now
headerText, but sample values still say “... title (optional)”, which can confuse consumers reading Storybook docs.Suggested copy-only diff
- headerText: 'Base title (optional)', + headerText: 'Base header (optional)', @@ - headerText: 'Critical title (optional)', + headerText: 'Critical header (optional)', @@ - headerText: 'Info title (optional)', + headerText: 'Info header (optional)', @@ - headerText: 'Positive title (optional)', + headerText: 'Positive header (optional)', @@ - headerText: 'Warning title (optional)', + headerText: 'Warning header (optional)',Also applies to: 167-167, 181-181, 195-195, 209-209
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/dialtone-vue/components/toast/toast.stories.js` at line 149, Update the Storybook sample text to match the prop name change: replace occurrences of wording that say "title" with "header" for the toast story props (e.g., the headerText prop in toast.stories.js and the sample entries referencing it around the lines indicated); specifically update the sample strings like 'Base title (optional)' to 'Base header (optional)' (and the other similar samples at the other noted positions) so the displayed documentation matches the headerText prop API.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/dialtone-vue/components/toast/toast.stories.js`:
- Around line 48-53: Update the commit message for edd98b24 to include the
required BREAKING CHANGE footer so consumers are notified of the prop rename;
amend the commit (or interactive rebase if it's not the most recent commit) and
append the exact line: "BREAKING CHANGE: Renamed Toast (and other component)
props: title/titleId → headerText/headerId", then force-push the branch so the
updated message replaces the old one. Reference the changed prop names
headerText and headerId and the original names title and titleId when crafting
the commit message.
---
Nitpick comments:
In `@packages/dialtone-vue/components/toast/toast.stories.js`:
- Line 149: Update the Storybook sample text to match the prop name change:
replace occurrences of wording that say "title" with "header" for the toast
story props (e.g., the headerText prop in toast.stories.js and the sample
entries referencing it around the lines indicated); specifically update the
sample strings like 'Base title (optional)' to 'Base header (optional)' (and the
other similar samples at the other noted positions) so the displayed
documentation matches the headerText prop API.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: eb0c39e9-b854-46b2-9282-1d31cc4a5473
📒 Files selected for processing (8)
packages/dialtone-vue/components/banner/banner.vuepackages/dialtone-vue/components/modal/modal.vuepackages/dialtone-vue/components/notice/notice.vuepackages/dialtone-vue/components/notice/notice_content.vuepackages/dialtone-vue/components/toast/layouts/toast_layout_alternate.vuepackages/dialtone-vue/components/toast/layouts/toast_layout_default.vuepackages/dialtone-vue/components/toast/toast.stories.jspackages/dialtone-vue/recipes/leftbar/callbox/callbox.vue
🚧 Files skipped from review as they are similar to previous changes (7)
- packages/dialtone-vue/recipes/leftbar/callbox/callbox.vue
- packages/dialtone-vue/components/modal/modal.vue
- packages/dialtone-vue/components/toast/layouts/toast_layout_default.vue
- packages/dialtone-vue/components/notice/notice.vue
- packages/dialtone-vue/components/toast/layouts/toast_layout_alternate.vue
- packages/dialtone-vue/components/notice/notice_content.vue
- packages/dialtone-vue/components/banner/banner.vue
Contributor
|
✔️ Deploy previews ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor props to not have native html attributes names
🛠️ Type Of Change
📖 Jira Ticket
https://dialpad.atlassian.net/browse/DLT-3284
📖 Description
Components Updated
title→headerText,titleslot →header,titleId→headerIdtitle→headerText,bannerTitle→bannerHeaderTexttitle→headerTextUpdated usages in combinator too.
Breaking Changes Summary
Renamed Props
Renamed Slots
Migration Required
Any consumer of these components that passes title, titleId, or bannerTitle as props, or uses a #title slot, will need to update to the new names. Specifically:
Not Affected