feat(localization): DLT-2461 refactor components by juliodialpad · Pull Request #724 · dialpad/dialtone

Julio Ortega (juliodialpad) · 2025-04-21T18:04:05Z

Refactor components to use localization

Obligatory GIF (super important!)

🛠️ Type Of Change

These types will increment the version number on release:

Feature

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2461

📖 Description

Migrated first set of componentes, will break this into multiple PRs to ease the review process as there might be a lot of changes happening.

💡 Context

We're implementing localization on Dialtone.

📝 Checklist

For all PRs:

I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
I have reviewed my changes.
I have added all relevant documentation.
I have considered the performance impact of my change.

For all Vue changes:

I have added / updated unit tests.
I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
I have validated components with a screen reader.
I have validated components keyboard navigation.

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

# Conflicts: # .github/workflows/publish-android.yml # .github/workflows/publish-ios.yml # .github/workflows/publish-web.yml # .github/workflows/visual_tests.yml # packages/dialtone-vue2/.storybook/preview.jsx # packages/dialtone-vue2/components/popover/popover.vue # packages/dialtone-vue2/components/popover/popover_default.story.vue # packages/dialtone-vue2/components/popover/popover_header_footer.vue # packages/dialtone-vue2/localization/index.js # pnpm-lock.yaml

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Julio Ortega (juliodialpad) · 2025-04-21T19:25:11Z

Separated banner from notice as they might have different props so it's easier to maintain them separately than overriding props here.

Julio Ortega (juliodialpad) · 2025-04-21T19:27:30Z


 import DtComboboxDefaultTemplate from './combobox_default.story.vue';
-import { LABEL_SIZES } from './combobox_constants';
+import { COMBOBOX_LABEL_SIZES } from './combobox_constants';


Renamed to match our specifications about prefixing the constants with the component name.

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Brad Paugh (braddialpad) · 2025-04-24T17:51:35Z

      <dt-tooltip
-        :message="nextMonthLabel"
+        :fallback-placements="['top-end', 'auto']"
+        :message="$t('NEXT_MONTH')"


Should we prefix this with component name DATEPICKER_NEXT_MONTH? or is it not necessary?

Yes, thanks for pointing out that, we should follow the same rules as our constants.

Brad Paugh (braddialpad) · 2025-04-24T18:33:08Z

Some error happening in percy, guessing maybe that won't be fixed until the migration is fully complete?

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

github-actions · 2025-04-28T01:51:25Z

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-724/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-724/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-724/

Julio Ortega (juliodialpad) · 2025-04-28T01:55:10Z

Some error happening in percy, guessing maybe that won't be fixed until the migration is fully complete?

It was failing on the base i18n/brase-branch branch, it is working correctly now, that's why there was a difference.

Julio Ortega (juliodialpad) · 2025-04-28T20:35:30Z

Merging this one, It's getting difficult to continue working on localization without this changes in.

Brad Paugh (braddialpad) · 2025-04-28T20:38:53Z

It's good, thanks!

Julio Ortega (juliodialpad) added 30 commits April 2, 2025 17:26

setup localization

f8c05ad

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

update i18n version

f30042c

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

translate to dialpadistan

87c99b9

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

test on attachment_carousel

65eed8e

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

temporarily remove with type json

c419f05

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

remove from attachment_carousel

2a7b3c9

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add more strings

81f283c

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

translate to dialpadistan

8b301f6

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

manually translate to spanish to test

33b1430

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add spanish to allowed locales

fe0ccea

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

test on popover

e001527

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add with type json back

b222e3a

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Merge branch 'staging' into dlt-2452-setup-i18n

0ae6508

remove unneeded changes

e986b4b

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add github @dialpad:registry config

cc5a7c4

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add packages read permission

bbfcc5d

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix deploy-preview

b16a230

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

try moving read packages to the right place

249ac9a

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

update package version

15fb32f

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

update package versions

52d0404

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

remove unneeded ts configs

78a5798

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

remove packages read

7a85e8f

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

update actions

d1e7d28

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

add closeButtonProps back

5b8ad0d

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

merge close button props and localized aria-label and title

d3c0ee0

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

update pnpm-lock

ade1ab3

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Merge branch 'refs/heads/staging' into i18n/refactor-components

93f5113

remove close button mixin and add localization mixin

e3234f1

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

migrate notice

ffa5908

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Julio Ortega (juliodialpad) requested a review from Nina Repetto (ninamarina) as a code owner April 21, 2025 18:04

Julio Ortega (juliodialpad) self-assigned this Apr 21, 2025

Julio Ortega (juliodialpad) added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Apr 21, 2025

Merge branch 'i18n/base-branch' into i18n/refactor-components

e6c2565

Julio Ortega (juliodialpad) marked this pull request as draft April 21, 2025 19:16

rollback undesired changes

61c5300

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Julio Ortega (juliodialpad) commented Apr 21, 2025

View reviewed changes

Julio Ortega (juliodialpad) added 9 commits April 21, 2025 13:31

fix label sizes

2aa52b2

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix notice tests

ba32e5c

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix notice_action tests

66b8da3

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix chip tests

fc12c46

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Merge branch 'i18n/base-branch' into i18n/refactor-components

4402639

fix checkbox tests

46f3362

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

remove index

dd0f603

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix tests

83abf43

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

fix tests

ada790b

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Julio Ortega (juliodialpad) marked this pull request as ready for review April 21, 2025 22:24

Merge branch 'i18n/base-branch' into i18n/refactor-components

b389270

Julio Ortega (juliodialpad) changed the title ~~feat(localization): DLT-2461 refactor-components~~ feat(localization): DLT-2461 refactor components Apr 23, 2025

Brad Paugh (braddialpad) reviewed Apr 24, 2025

View reviewed changes

prefix fluent strings

a844646

Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>

Julio Ortega (juliodialpad) requested a review from Brad Paugh (braddialpad) April 28, 2025 15:49

Julio Ortega (juliodialpad) merged commit 1a01493 into i18n/base-branch Apr 28, 2025
11 checks passed

Julio Ortega (juliodialpad) deleted the i18n/refactor-components branch April 28, 2025 20:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(localization): DLT-2461 refactor components#724

feat(localization): DLT-2461 refactor components#724
Julio Ortega (juliodialpad) merged 52 commits intoi18n/base-branchfrom
i18n/refactor-components

Julio Ortega (juliodialpad) commented Apr 21, 2025 •

edited

Loading

Uh oh!

Julio Ortega (juliodialpad) Apr 21, 2025

Uh oh!

Julio Ortega (juliodialpad) Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brad Paugh (braddialpad) Apr 24, 2025

Uh oh!

Julio Ortega (juliodialpad) Apr 24, 2025

Uh oh!

Brad Paugh (braddialpad) commented Apr 24, 2025

Uh oh!

github-actions Bot commented Apr 28, 2025

Uh oh!

Julio Ortega (juliodialpad) commented Apr 28, 2025

Uh oh!

Julio Ortega (juliodialpad) commented Apr 28, 2025

Uh oh!

Uh oh!

Brad Paugh (braddialpad) commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Julio Ortega (juliodialpad) commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refactor components to use localization

Obligatory GIF (super important!)

🛠️ Type Of Change

📖 Jira Ticket

📖 Description

💡 Context

📝 Checklist

Uh oh!

Julio Ortega (juliodialpad) Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

Julio Ortega (juliodialpad) Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brad Paugh (braddialpad) Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Julio Ortega (juliodialpad) Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Brad Paugh (braddialpad) commented Apr 24, 2025

Uh oh!

github-actions Bot commented Apr 28, 2025

Uh oh!

Julio Ortega (juliodialpad) commented Apr 28, 2025

Uh oh!

Julio Ortega (juliodialpad) commented Apr 28, 2025

Uh oh!

Uh oh!

Brad Paugh (braddialpad) commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Julio Ortega (juliodialpad) commented Apr 21, 2025 •

edited

Loading