fix(checkbox, radio): NO-JIRA description slot not being reactive#725
Merged
Nina Repetto (ninamarina) merged 1 commit intostagingfrom Apr 21, 2025
Merged
fix(checkbox, radio): NO-JIRA description slot not being reactive#725Nina Repetto (ninamarina) merged 1 commit intostagingfrom
Nina Repetto (ninamarina) merged 1 commit intostagingfrom
Conversation
Nina Repetto (ninamarina)
force-pushed
the
fix/checkbox-radio
branch
from
7419754 to
9661b4f
Compare
Contributor
|
Please add either the |
Brad Paugh (braddialpad)
approved these changes
Apr 21, 2025
Contributor
Brad Paugh (braddialpad)
left a comment
Brad Paugh (braddialpad)
left a comment
There was a problem hiding this comment.
Oh yeah, makes sense because $slots isn't reactive. Good fix thanks!
Contributor
|
✔️ Deploy previews ready! |
Nina Repetto (ninamarina)
added
the
no-visual-test
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 21, 2025
## [2.184.1](dialtone-vue2/v2.184.0...dialtone-vue2/v2.184.1) (2025-04-21) ### Bug Fixes * **Checkbox, Radio:** NO-JIRA description slot not being reactive ([#725](#725)) ([7a29e67](7a29e67))
Julio Ortega (juliodialpad)
pushed a commit
that referenced
this pull request
Apr 21, 2025
## [3.177.1](dialtone-vue3/v3.177.0...dialtone-vue3/v3.177.1) (2025-04-21) ### Bug Fixes * **Checkbox, Radio:** NO-JIRA description slot not being reactive ([#725](#725)) ([7a29e67](7a29e67))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(checkbox, radio): NO-JIRA description slot not being reactive
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
No jira, we found out about this with a test failing in Firespotter: https://github.com/dialpad/firespotter/pull/56110
📖 Description
Since
$slotsisn't reactive, it doesn't re render the component when passing thedescriptionslot. Moving the logic back inline instead of in a computed property makes it work again.