Conversation
jbeilstenedmands
force-pushed
the
add_models
branch
from
ab8657c to
d8da1ed
Compare
ndevenish
pushed a commit
that referenced
this pull request
Jan 20, 2025
Add some initial models to get started. Beam and goniometer are more complete, scan, detector and crystal less so. Adds a dependency on gemmi for crystal symmetry and cell operations. Add an example test creating a crystal to test the install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some initial models to get started. Beam and goniometer are more complete, scan, detector and crystal less so.
Adds a dependency on gemmi for crystal symmetry and cell operations.
Add an example test creating a crystal to test the install.