Add some missing methods to the experiment models.#14
Merged
jbeilstenedmands merged 7 commits intodials:mainfrom Jul 1, 2025
Merged
Add some missing methods to the experiment models.#14jbeilstenedmands merged 7 commits intodials:mainfrom
jbeilstenedmands merged 7 commits intodials:mainfrom
Conversation
for more information, see https://pre-commit.ci
yash4karan
pushed a commit
to yash4karan/dx2
that referenced
this pull request
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few new methods for updating experiment models or getting attributes, which I found I needed for my indexer work.
It also includes a few fixes to loading and saving experiments such that required properties are correctly propagated from loading to saving, so that dials can understand dx2 generated files.