Assign item.dwBuff in items.cpp:RecreateItem()

	Make absolutely certain that the item.dwBuff flag is always set
	for all items, regardless of how the function gets called.

Remove unnecessary item.dwBuff assignments

	Since item.dwBuff is now set in RecreateItem(), these
	assignments are unnecessary.

Author: Yggdrasill

Source/inv.cpp

@@ -1886,7 +1886,6 @@ int SyncDropItem(Point position, _item_indexes idx, uint16_t icreateinfo, int is
 		item._iPLToHit = ClampToHit(item, toHit);
 		item._iMaxDam = ClampMaxDam(item, maxDam);
 	}
-	item.dwBuff = ibuff;
 
 	return PlaceItemInWorld(std::move(item), position);
 }

Source/items.cpp

@@ -3512,7 +3512,8 @@ void CreateTypeItem(Point position, bool onlygood, ItemType itemType, int imisc,
 void RecreateItem(const Player &player, Item &item, _item_indexes idx, uint16_t icreateinfo, uint32_t iseed, int ivalue, uint32_t dwBuff)
 {
 	bool tmpIsHellfire = gbIsHellfire;
-	gbIsHellfire = dwBuff & CF_HELLFIRE;
+	item.dwBuff = dwBuff;
+	gbIsHellfire = item.dwBuff & CF_HELLFIRE;
 
 	if (idx == IDI_GOLD) {
 		InitializeItem(item, IDI_GOLD);
@@ -3556,7 +3557,7 @@ void RecreateItem(const Player &player, Item &item, _item_indexes idx, uint16_t
 	bool onlygood = (icreateinfo & CF_ONLYGOOD) != 0;
 	bool forceNotUnique = (icreateinfo & CF_UNIQUE) == 0;
 	bool pregen = (icreateinfo & CF_PREGEN) != 0;
-	auto uidOffset = static_cast<int>((dwBuff & CF_UIDOFFSET) >> 1);
+	auto uidOffset = static_cast<int>((item.dwBuff & CF_UIDOFFSET) >> 1);
 
 	SetupAllItems(player, item, idx, iseed, level, uper, onlygood, pregen, uidOffset, forceNotUnique);
 	SetupItem(item);

Source/msg.cpp

@@ -2429,7 +2429,6 @@ void PrepareEarForNetwork(const Item &item, TEar &ear)
 void RecreateItem(const Player &player, const TItem &messageItem, Item &item)
 {
 	const uint32_t dwBuff = SDL_SwapLE32(messageItem.dwBuff);
-	item.dwBuff = dwBuff;
 	RecreateItem(player, item,
 	    static_cast<_item_indexes>(SDL_SwapLE16(messageItem.wIndx)), SDL_SwapLE16(messageItem.wCI),
 	    SDL_SwapLE32(messageItem.dwSeed), SDL_SwapLE16(messageItem.wValue), dwBuff);