-
Notifications
You must be signed in to change notification settings - Fork 0
memory: comprehensive week retrospective -- PT/orama collab Lessons #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
de9fd0b
memory: comprehensive week retrospective -- PT/orama collaboration le…
diazMelgarejo a9315a9
ci+docs: exempt SKILL.md from markdownlint, fix retrospective's last …
diazMelgarejo 33fe697
fix: PR #317 review 4834174248 -- focused lesson conditions, dedupe e…
diazMelgarejo 8401775
fix(memory): PR #317 review — remove legacy episodic row, skip in replay
diazMelgarejo 0c8eea2
fix(memory): re-encode archived legacy episodic row with canonical sc…
diazMelgarejo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "id": "2d53056e593c", | ||
| "key": "manual_2d5305", | ||
| "name": "manual_2d5305", | ||
| "claim": "Several tooling and API gotchas recur across a working session even after being individually caught once, because a single encounter doesn't automatically generalize into a standing rule: the PR-list API's merged field being unreliable (must check the single-PR endpoint); squash-merged branches never showing as git ancestors (verify by content/ID presence, not ancestry); a stale local checkout after an earlier push in the same session diverging silently; and diff-scoped CI lint checking a whole touched file, not just the changed hunk. Each of these needs to be treated as a standing checklist item to consult before the relevant operation, not a one-off lesson learned and then re-derived from scratch the next time it's encountered.", | ||
| "conditions": [ | ||
| "pr-list-merged-field", | ||
| "squash-merge-ancestry", | ||
| "diff-scoped-lint", | ||
| "stale-checkout", | ||
| "recurring-gotcha" | ||
| ], | ||
| "evidence_ids": [ | ||
| "2026-08-01T06:53:43.671436+00:00" | ||
| ], | ||
| "cluster_size": 1, | ||
| "canonical_salience": 8.0, | ||
| "staged_at": "2026-08-01T06:53:43.671436+00:00", | ||
| "status": "accepted", | ||
| "decisions": [ | ||
| { | ||
| "ts": "2026-08-01T06:53:43.671436+00:00", | ||
| "action": "staged", | ||
| "reviewer": "learn" | ||
| }, | ||
| { | ||
| "ts": "2026-08-01T06:53:50.650448+00:00", | ||
| "action": "graduated", | ||
| "reviewer": "host-agent", | ||
| "notes": "Several gotchas recurred even after individual capture -- worth the meta-lesson that a checklist consulted before the operation, not recall alone, is what actually prevents repetition.", | ||
| "provisional": false, | ||
| "evidence_snapshot": [ | ||
| "2026-08-01T06:53:43.671436+00:00" | ||
| ], | ||
| "lessons_sha": "4bce83c74754" | ||
| } | ||
| ], | ||
| "rejection_count": 0, | ||
| "accepted_at": "2026-08-01T06:53:50.650434+00:00", | ||
| "reviewer": "host-agent", | ||
| "rationale": "Several gotchas recurred even after individual capture -- worth the meta-lesson that a checklist consulted before the operation, not recall alone, is what actually prevents repetition." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "id": "718c9430f44b", | ||
| "key": "manual_718c94", | ||
| "name": "manual_718c94", | ||
| "claim": "When resolving real overlap between a new draft and an existing, more comprehensive doctrine, \"avoid duplication\" does not automatically mean \"make the newer, simpler thing subordinate to the older, more complex one.\" It means determining which document actually serves which situation and sizing each to its own job. A heavyweight protocol built for a rare, hard problem (e.g. concurrent multi-agent edits to the same repo, or reconciling a fork separated from its source by months of drift) should not become the default an agent reads first for the common, simple case (one branch, one agent, no concurrent editing) just because it existed first and is more thorough. Getting this backwards is not caught by re-reading a project's own stated single-source-of-truth value, since that value is genuinely being honored in some sense (no literal duplication) even while the sizing is wrong -- it may require direct correction from a human collaborator who can see the actual audience mismatch.", | ||
| "conditions": [ | ||
| "doctrine-overlap", | ||
| "thin-addendum", | ||
| "subordinate-doc", | ||
| "single-source-of-truth", | ||
| "worktree-merge-card" | ||
| ], | ||
| "evidence_ids": [ | ||
| "2026-08-01T06:53:43.608740+00:00" | ||
| ], | ||
| "cluster_size": 1, | ||
| "canonical_salience": 8.0, | ||
| "staged_at": "2026-08-01T06:53:43.608740+00:00", | ||
| "status": "accepted", | ||
| "decisions": [ | ||
| { | ||
| "ts": "2026-08-01T06:53:43.608740+00:00", | ||
| "action": "staged", | ||
| "reviewer": "learn" | ||
| }, | ||
| { | ||
| "ts": "2026-08-01T06:53:50.501493+00:00", | ||
| "action": "graduated", | ||
| "reviewer": "host-agent", | ||
| "notes": "The hierarchy-inversion mistake this session, requiring direct human correction rather than self-catching -- worth a durable lesson about resolving overlap correctly, not just avoiding literal duplication.", | ||
| "provisional": false, | ||
| "evidence_snapshot": [ | ||
| "2026-08-01T06:53:43.608740+00:00" | ||
| ], | ||
| "lessons_sha": "c7f4daa0894a" | ||
| } | ||
| ], | ||
| "rejection_count": 0, | ||
| "accepted_at": "2026-08-01T06:53:50.501478+00:00", | ||
| "reviewer": "host-agent", | ||
| "rationale": "The hierarchy-inversion mistake this session, requiring direct human correction rather than self-catching -- worth a durable lesson about resolving overlap correctly, not just avoiding literal duplication." | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: diazMelgarejo/Perpetua-Tools
Length of output: 6507
🏁 Script executed:
Repository: diazMelgarejo/Perpetua-Tools
Length of output: 50385
🏁 Script executed:
Repository: diazMelgarejo/Perpetua-Tools
Length of output: 26421
Document or preserve filtered legacy episodes.
_load_entries_locked()skipsdate/summaryrows when canonical rows exist, thenrun_dream_cycle()writes onlykeptback toAGENT_LEARNINGS.jsonl. This silently removes those legacy rows from the persistent store unless the file contains only legacy rows. If filtering is replay-only, archive them independently; otherwise add a test/docs note documenting the cleanup policy.🤖 Prompt for AI Agents