-
Notifications
You must be signed in to change notification settings - Fork 0
feat(security): guard-sync + PR-body HMAC grant v2 (pairs orama #260) #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b5b8937
fix(guard-sync): worktree discovery, fail-closed checker, full pre-pu…
diazMelgarejo ed21357
docs(memory): combine CodeRabbit review wave report + graduate lessons
diazMelgarejo 4287948
fix(pr-body): sync remind-pr-body Layer 0 messaging from orama #255
diazMelgarejo 6a5a1db
feat(security): sync HMAC grant v2 PR-body path from orama-system
diazMelgarejo 0c3506d
docs(memory): chronicle PR-body HMAC grant MVP saga (2026-08-02)
diazMelgarejo 5a154a0
docs(memory): weld verification + research export index
diazMelgarejo 4ca359b
fix(security): sync grant remediation F1–F7 from orama canonical
diazMelgarejo fd08ef1
docs(agent): refresh grant remediation memory across PT .agent
diazMelgarejo 091e2fa
sync(grant): scrub_dsstore + can-6 remediation from orama #260
diazMelgarejo ecdeec1
fix: PT PR #320 remediation (can-7.md) + 4 lessons from this session
diazMelgarejo fdd0a0f
fix: markdownlint config schema mismatch -- CI's pinned action runs a…
diazMelgarejo 1ccca81
fix(memory,ci): restore superseded lesson link + MD013-only markdownl…
diazMelgarejo 6be84e4
memory: 3 lessons + report from the markdownlint version-mismatch / g…
diazMelgarejo 1ba754e
merge: integrate ci-version-mismatch lessons (6be84e4) into PR #320
diazMelgarejo bf0a3e4
fix: revert regression -- restore working markdownlint ignores config
diazMelgarejo 875cb81
sync: propagate orama PR #260's guard-script fixes to PT exactly
diazMelgarejo 3719a49
memory: dispatch-race/config-scope postmortem + 3 lessons from orama …
diazMelgarejo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "id": "64e972d330c2", | ||
| "key": "manual_64e972", | ||
| "name": "manual_64e972", | ||
| "claim": "When markdownlint-cli2 v0.17.2 lints explicit file globs in CI, root .markdownlint.json filter overrides do not apply to catalog SKILL.md files outside the skills tree \u2014 add a per-directory .markdownlint-cli2.jsonc (e.g. line_length 500 for bin/orama-system/) and delete conflicting .markdownlint.json.", | ||
| "conditions": [ | ||
| "CI", | ||
| "MD013", | ||
| "SKILL.md", | ||
| "cli2", | ||
| "filter", | ||
| "markdownlint" | ||
| ], | ||
| "evidence_ids": [ | ||
| "2026-08-01T16:22:59.457445+00:00" | ||
| ], | ||
| "cluster_size": 1, | ||
| "canonical_salience": 8.0, | ||
| "staged_at": "2026-08-01T16:22:59.457445+00:00", | ||
| "status": "accepted", | ||
| "decisions": [ | ||
| { | ||
| "ts": "2026-08-01T16:22:59.457445+00:00", | ||
| "action": "staged", | ||
| "reviewer": "learn" | ||
| }, | ||
| { | ||
| "ts": "2026-08-01T16:22:59.533279+00:00", | ||
| "action": "graduated", | ||
| "reviewer": "learn.py", | ||
| "notes": "orama PR #255 CI runs 30704939323 and 30706305712 failed MD013 on bin/orama-system/SKILL.md until per-directory cli2 config landed in commits d6d3763a and 861f78ca.", | ||
| "provisional": false, | ||
| "evidence_snapshot": [ | ||
| "2026-08-01T16:22:59.457445+00:00" | ||
| ], | ||
| "lessons_sha": "e0a0dcd77a83" | ||
| } | ||
| ], | ||
| "rejection_count": 0, | ||
| "accepted_at": "2026-08-01T16:22:59.533269+00:00", | ||
| "reviewer": "learn.py", | ||
| "rationale": "orama PR #255 CI runs 30704939323 and 30706305712 failed MD013 on bin/orama-system/SKILL.md until per-directory cli2 config landed in commits d6d3763a and 861f78ca." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "id": "82c94865243e", | ||
| "key": "manual_82c948", | ||
| "name": "manual_82c948", | ||
| "claim": "Guard-sync divergence checks must discover workspace siblings via git -C path rev-parse --show-toplevel (not test -d path/.git), reject surplus CLI arguments with exit 2, fail-closed when check-guard-sync-divergence.sh is missing, and scan the full outgoing pre-push commit range for scripts/git/ touches.", | ||
| "conditions": [ | ||
| "divergence", | ||
| "fail-closed", | ||
| "guard-sync", | ||
| "pre-push", | ||
| "worktree" | ||
| ], | ||
| "evidence_ids": [ | ||
| "2026-08-01T16:22:59.581970+00:00" | ||
| ], | ||
| "cluster_size": 1, | ||
| "canonical_salience": 8.0, | ||
| "staged_at": "2026-08-01T16:22:59.581970+00:00", | ||
| "status": "accepted", | ||
| "decisions": [ | ||
| { | ||
| "ts": "2026-08-01T16:22:59.581970+00:00", | ||
| "action": "staged", | ||
| "reviewer": "learn" | ||
| }, | ||
| { | ||
| "ts": "2026-08-01T16:22:59.659940+00:00", | ||
| "action": "graduated", | ||
| "reviewer": "learn.py", | ||
| "notes": "CodeRabbit reviews 4835024659 and 4835288649 on orama #255 \u2014 commits dd8bcba3 and 458a5ab9; linked worktree siblings were invisible to .git directory checks.", | ||
| "provisional": false, | ||
| "evidence_snapshot": [ | ||
| "2026-08-01T16:22:59.581970+00:00" | ||
| ], | ||
| "lessons_sha": "ddf7e73da8d4" | ||
| } | ||
| ], | ||
| "rejection_count": 0, | ||
| "accepted_at": "2026-08-01T16:22:59.659928+00:00", | ||
| "reviewer": "learn.py", | ||
| "rationale": "CodeRabbit reviews 4835024659 and 4835288649 on orama #255 \u2014 commits dd8bcba3 and 458a5ab9; linked worktree siblings were invisible to .git directory checks." | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "id": "8c5f6349aa87", | ||
| "key": "manual_8c5f63", | ||
| "name": "manual_8c5f63", | ||
| "claim": "PR body Layer 0: Cursor agents comment only (post_comment or gh pr comment). Body writes require an operator TTY grant via grant-pr-body-human-override.sh; only append-pr-body.sh is allowed after grant \u2014 never update_pr body=, gh pr edit, gh api body mutations, or agent-forgeable env exports.", | ||
| "conditions": [ | ||
| "Layer0", | ||
| "TTY", | ||
| "append-only", | ||
| "grant", | ||
| "operator", | ||
| "pr-body" | ||
| ], | ||
| "evidence_ids": [ | ||
| "2026-08-01T16:22:59.706278+00:00" | ||
| ], | ||
| "cluster_size": 1, | ||
| "canonical_salience": 8.0, | ||
| "staged_at": "2026-08-01T16:22:59.706278+00:00", | ||
| "status": "accepted", | ||
| "decisions": [ | ||
| { | ||
| "ts": "2026-08-01T16:22:59.706278+00:00", | ||
| "action": "staged", | ||
| "reviewer": "learn" | ||
| }, | ||
| { | ||
| "ts": "2026-08-01T16:22:59.775197+00:00", | ||
| "action": "graduated", | ||
| "reviewer": "learn.py", | ||
| "notes": "CodeRabbit 4835288649 commit 88783688 closed the override bypass chain after agents clobbered PT #319 description with delta-only update_pr.", | ||
| "provisional": false, | ||
| "evidence_snapshot": [ | ||
| "2026-08-01T16:22:59.706278+00:00" | ||
| ], | ||
| "lessons_sha": "b37edefc9917" | ||
| } | ||
| ], | ||
| "rejection_count": 0, | ||
| "accepted_at": "2026-08-01T16:22:59.775187+00:00", | ||
| "reviewer": "learn.py", | ||
| "rationale": "CodeRabbit 4835288649 commit 88783688 closed the override bypass chain after agents clobbered PT #319 description with delta-only update_pr." | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.