Merge pull request #14 from diazMelgarejo/cursor/periscope-desktop-sidecar-f559

fix(desktop): align runtime sidecar stem with bundled binary

Author: cursor[bot]

desktop/scripts/test-desktop-workflows.sh

@@ -6,6 +6,7 @@ REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
 ARTIFACTS_WORKFLOW="$REPO_ROOT/.github/workflows/desktop-artifacts.yml"
 RELEASE_WORKFLOW="$REPO_ROOT/.github/workflows/desktop-release.yml"
 DOC_FILE="$REPO_ROOT/docs/desktop-release-setup.md"
+TAURI_LIB="$REPO_ROOT/desktop/src-tauri/src/lib.rs"
 
 assert_contains() {
   local file="$1"
@@ -64,4 +65,11 @@ assert_not_contains "$RELEASE_WORKFLOW" 'linux-aarch64' \
 assert_contains "$DOC_FILE" "AgentsView_x.y.z_aarch64.AppImage" \
   "desktop release docs should mention the Linux arm64 AppImage"
 
+assert_contains "$TAURI_LIB" 'sidecar("periscope")' \
+  "Tauri runtime should spawn the configured periscope sidecar binary"
+assert_not_contains "$TAURI_LIB" 'sidecar("agentsview")' \
+  "Tauri runtime should not request the removed agentsview sidecar binary"
+assert_contains "$TAURI_LIB" 'home.join(".agentsview").join("desktop.env")' \
+  "desktop env override should retain the upstream-compatible agentsview path"
+
 echo "desktop workflow checks passed"

desktop/src-tauri/src/lib.rs

@@ -121,7 +121,7 @@ fn launch_backend(app: &mut App) -> Result<(), DynError> {
 
 fn spawn_sidecar(app: &App) -> Result<(CommandRx, CommandChild), DynError> {
     let port_arg = PREFERRED_PORT.to_string();
-    let mut command = app.shell().sidecar("agentsview")?;
+    let mut command = app.shell().sidecar("periscope")?;
     for (key, value) in sidecar_env() {
         command = command.env(key, value);
     }
@@ -198,7 +198,7 @@ fn is_allowed_external_open_url(url: &Url) -> bool {
 // sidecar_env returns the environment passed to the backend
 // sidecar process. It merges the app environment with
 // login-shell variables so desktop launches inherit zshrc/bash
-// exports. An optional ~/.periscope/desktop.env file can
+// exports. An optional legacy ~/.agentsview/desktop.env file can
 // override specific keys as an escape hatch.
 fn sidecar_env() -> Vec<(OsString, OsString)> {
     let skip_login_shell = std::env::var_os("AGENTSVIEW_DESKTOP_SKIP_LOGIN_SHELL_ENV");
@@ -241,9 +241,9 @@ fn default_login_shell() -> String {
     "/bin/sh".to_string()
 }
 
-// read_desktop_env_file parses ~/.periscope/desktop.env as
+// read_desktop_env_file parses the legacy ~/.agentsview/desktop.env as
 // KEY=VALUE lines. This provides a manual override path before
-// desktop settings UI exists.
+// desktop settings UI exists. Keep the path for upstream compatibility.
 fn read_desktop_env_file() -> Vec<(OsString, OsString)> {
     let Some(home) = resolve_home_dir() else {
         return Vec::new();