Bump reusable-workflow pin to v2.1.1; remove redundant cmake-version/conan-version overrides - #55
Merged
Conversation
v2.1.1 fixes both gaps that made removing these unsafe before: cmake-version default is now 4.4.2 (matching lukka/get-cmake@v4.4.2), and configure_conan's own conan-version default is now 2.31.2 (previously a stale 2.3.1 that broke clang-19+ builds). Both overrides now exactly duplicate the reusable workflow's own defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
dice-group/cpp-conan-release-reusable-workflowpin tov2.1.1and removes thecmake-version/conan-versionoverrides that just duplicated its defaults.v2.1.1fixes the two gaps that made this unsafe before:cmake-versiondefault is now4.4.2(matching thelukka/get-cmake@v4.4.2pin), andconfigure_conan's ownconan-versiondefault is now2.31.2(previously a stale2.3.1that brokeclang-19+ builds -- confirmed by CI failure on an earlier version of this PR in another repo). Both overrides now exactly duplicate what the reusable workflow already provides.Not merged -- ready for review.