implemented range adaptors#89
Merged
Merged
Conversation
6 tasks
6 tasks
liss-h
requested changes
Jun 10, 2025
liss-h
left a comment
liss-h
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR, I found a lot of code convention issues
bigerl
changed the base branch from
feature/squashing-range-addaptors
to
develop
bigerl
changed the title
liss-h
requested changes
Jun 10, 2025
liss-h
left a comment
liss-h
left a comment
Contributor
There was a problem hiding this comment.
I pushed a commit to clean up some things, please review the changes. Additionally, I have some more comments
bigerl
commented
Jun 10, 2025
liss-h
approved these changes
Jun 11, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the remaining range adaptors from #86 except for join.
I would like to get some feedback on the code before continuing with the examples and readme.