Skip to content

implement join for std::format#90

Merged
liss-h merged 6 commits into
developfrom
feature/fmt_join
Jun 10, 2025
Merged

implement join for std::format#90
liss-h merged 6 commits into
developfrom
feature/fmt_join

Conversation

@bigerl

@bigerl bigerl commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

last one from #86

This PR removes support for GCC 12, as std::format is only supported in GCC 13 and later.

@bigerl bigerl changed the base branch from main to develop June 6, 2025 15:06
liss-h
liss-h requested changes Jun 10, 2025
View reviewed changes

@liss-h liss-h left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question, and two cosmetic things that go against our style guide (and a request for the CI)

Comment thread .github/workflows/code_testing.yaml
Comment thread include/dice/template-library/fmt_join.hpp
Comment thread include/dice/template-library/fmt_join.hpp Outdated
Comment thread include/dice/template-library/fmt_join.hpp Outdated
@bigerl bigerl requested a review from liss-h June 10, 2025 12:54
@liss-h liss-h merged commit 364fd15 into develop Jun 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liss-h liss-h liss-h approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bigerl @liss-h