Added Prototype Implementation and Examples for OWL Justification Feature#148
Closed
Balramt wants to merge 10 commits into
Closed
Added Prototype Implementation and Examples for OWL Justification Feature#148Balramt wants to merge 10 commits into
Balramt wants to merge 10 commits into
Conversation
alkidbaci
reviewed
Jun 25, 2025
Collaborator
There was a problem hiding this comment.
I believe you mistakenly edited this file.
jpype is not necessary here
alkidbaci
reviewed
Jun 25, 2025
|
|
||
|
|
||
| class SyncReasoner(AbstractOWLReasoner): | ||
| def create_justifications(self, owl_individuals: Set[OWLNamedIndividual] = None, |
Collaborator
There was a problem hiding this comment.
The signature of this method is different from the one I suggested here. The save argument is missing.
Collaborator
|
@Balramt Thank you for the PR. Please check the comments i left you. I edited the test a bit so make sure to pull the changes first. Also please fix the linting problem and all checks should pass before we merge this PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a prototype implementation of the create_justification method to support justification generation for OWL ontologies.