Configs and Log Refractor - #53
Open
srivastava-yash wants to merge 4 commits into
Open
Conversation
Author
|
@lucifercr07, I have implemented the configs refractor and also added a logging package. I was not entirely sure about the logging package. Happy to hear your suggestions and comments on changing anything. |
srivastava-yash
marked this pull request as draft
October 29, 2024 05:05
srivastava-yash
marked this pull request as ready for review
October 29, 2024 06:22
srivastava-yash
commented
Oct 29, 2024
| func handleCors(w http.ResponseWriter, r *http.Request) bool { | ||
| configValue := config.LoadConfig() | ||
| allAllowedOrigins := configValue.Server.AllowedOrigins | ||
| allAllowedOrigins := config.AppConfig.Server.AllowedOrigins |
Author
There was a problem hiding this comment.
Not sure why linter is failing here even though the config.LoadConfig is changed here..getting linter error where this function is called in internal/middleware/ratelimiter.go
Contributor
|
@srivastava-yash can you please fix the build and lint issue. |
Author
|
Sorry for the delay on this @lucifercr07 , I was traveling. When I am running the lint command locally, I am not getting any errors. I am not sure why linter is failing, I had mentioned this in a comment earlier as well. I will try to debug this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44