Open
Conversation
dicej
force-pushed
the
wasip2-take2
branch
5 times, most recently
from
2998752 to
14a69d6
Compare
.github/workflows/ci.yml
Outdated
| - name: test tokio --target wasm32-wasip2 | ||
| # We currently need `+nightly` here due to some dependencies | ||
| # (e.g. `rustix`) which require `#![feature(wasip2)]`: | ||
| run: cargo +nightly nextest run --target wasm32-wasip2 --features net,macros,rt,io-util |
There was a problem hiding this comment.
How much work would it be to get cargo test working? E.g. how many annotations needed to ignore tests that don't compile or fail?
Owner
Author
There was a problem hiding this comment.
There are 69 doc tests failing at either compile time or runtime, so...lots.
dicej
force-pushed
the
wasip2-take2
branch
7 times, most recently
from
ed49484 to
e7ea20e
Compare
Motivation This adds networking support for the `wasm32-wasip2` target platform, which includes more extensive support for sockets than `wasm32-wasip1`. Solution The bulk of the changes are in tokio-rs/mio#1931. This patch mainly tweaks a few `cfg` directives to indicate `wasm32-wasip2`'s additional capabilities. Note that this is a draft PR until until tokio-rs/mio#1931 and rust-lang/socket2#639 have been include in stable releases of their respective projects. Also note that I've added a `wasm32-wasip2` target to CI and triaged each test which was previously disabled for WASI into one of three categories: - Disabled on both WASIp1 and p2 due to not-yet-supported features such as multithreading - Disabled on p1 but enabled on p2 - Disabled on p1 and _temporarily_ disabled on p2 due to `wasi-libc` bugfixes which have been merged but not yet included in a Rust release. I'll open an issue to re-enable them when the fixes land in Rust. Future Work In the future, we could consider adding support for `tokio::net::lookup_host`. WASIp2 natively supports asynchronous DNS lookups and is single threaded, whereas Tokio currently assumes DNS lookups are blocking and require multithreading to emulate async lookups. A WASIp2-specific implementation could do the lookup directly without multithreading. WASIp2 also supports single-threaded, asynchronous file I/O, timers, etc. We could either support those directly or wait for WASIp3's multithreading support, in which case most of `tokio::fs` (as well as `tokio::net::lookup_host`, etc.) _should_ work unchanged via `wasi-libc` and worker threads. Currently, building for WASIp2 requires RUSTFLAGS="--cfg tokio_unstable"`. Once we have a solid maintenance plan, we can remove that requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds networking support for the
wasm32-wasip2target platform, which includes more extensive support for sockets thanwasm32-wasip1.Solution
The bulk of the changes are in tokio-rs/mio#1931. This patch mainly tweaks a few
cfgdirectives to indicatewasm32-wasip2's additional capabilities.Note that this is a draft PR until until
tokio-rs/mio#1931 and
rust-lang/socket2#639 have been include in stable releases of their respective projects.
Also note that I've added a
test-wasitarget to CI and triaged each test which was previously disabled for WASI into one of three categories:wasi-libcbugfixes which have been merged but not yet included in a Rust release. I'll open an issue to re-enable them when the fixes land in Rust.Future Work
In the future, we could consider adding support for
tokio::net::lookup_host. WASIp2 natively supports asynchronous DNS lookups and is single threaded, whereas Tokio currently assumes DNS lookups are blocking and require multithreading to emulate async lookups. A WASIp2-specific implementation could do the lookup directly without multithreading.WASIp2 also supports single-threaded, asynchronous file I/O, timers, etc. We could either support those directly or wait for WASIp3's multithreading support, in which case most of
tokio::fs(as well astokio::net::lookup_host, etc.) should work unchanged viawasi-libcand worker threads.Currently, building for WASIp2 requires both
nightlyRust andRUSTFLAGS="--cfg tokio_unstable". Thenightlyrequirement could be removed once either thefeature(wasip2)is stabilized orrustixis updated not to use it. It would be nice to remove the--cfg tokio_unstablerequirement as well, assuming we have a solid maintainance plan.