Repository navigation
Fixes 'Choose N' rule hijacks Dragon's Choose command - #69
Merged
quintijn merged 5 commits intoJul 23, 2026
Merged
Conversation
_general.py: Renames 'choose' rule to be 'pick'.
dw96
marked this pull request as ready for review
April 21, 2026 11:18
dw96
marked this pull request as draft
April 21, 2026 11:20
dw96
marked this pull request as ready for review
April 21, 2026 11:20
Collaborator
|
Christian, let us discuss this one first! A bit busy these days, maybe Friday will fit... |
Contributor
Author
dw96
force-pushed
the
ca_unimacro_april26
branch
2 times, most recently
from
May 7, 2026 10:16
ba639f7 to
398b8f5
Compare
dw96
force-pushed
the
ca_unimacro_april26
branch
from
July 22, 2026 15:58
148aa30 to
c6cffc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragon's built-in Choose N becomes available when there are multiple choices, such as which programme to choose after saying "List Programs".
_generaldefines a conflicting Choose N rule (where N = 1-10). This PR addresses the above conflict by renaming_general's 'choose' rule to be 'pick'.Separately, I discover that there is a wider problem with this rule. It produces an Exception when triggered. I will need to revisit this PR to debug this: