5.6~5.9 issue fix round 1#2143
Merged
boyongjiong merged 3 commits intomasterfrom May 8, 2025
Merged
Conversation
|
boyongjiong
reviewed
May 8, 2025
|
|
||
| setMode(mode: IMode) { | ||
| public setMode(mode: IMode) { | ||
| console.log('setMode', mode) |
boyongjiong
reviewed
May 8, 2025
| } | ||
|
|
||
| highlight(id: string, mode: IMode = this.mode) { | ||
| console.log('highlight', id, mode) |
boyongjiong
reviewed
May 8, 2025
| this.lf.graphModel.getNodeModelById(targetNodeId) | ||
| const dropPointIsAnchor = targetNodeModel?.anchors.some((anchor) => { | ||
| const { x, y } = anchor | ||
| return Math.abs(eventX - x) <= 10 && Math.abs(eventY - y) <= 10 |
Collaborator
There was a problem hiding this comment.
确认下如果锚点大小调整了，会不会 dropPointIsAnchor 判断与实际不符
现在是判断 Math.abs(evtX - x) <= 10，相当于默认锚点大小为 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2138 #2140