Skip to content

fix(core): prevent unnecessary node re-renders during canvas zoom #2398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 2 commits into
base: master
Choose a base branch
from
+119 −14
Open

fix(core): prevent unnecessary node re-renders during canvas zoom #2398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df4338
fix(core): prevent unnecessary node re-renders during canvas zoom
cyphercodes Apr 5, 2026
99fdf5f
fix(core): update node drag step on pointer down
cyphercodes Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/view/node/BaseNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ export abstract class BaseNode<P extends IProps = IProps> extends Component<
allowResize,
},
gridSize,
transformModel: { SCALE_X },
transformModel,
} = graphModel
const { isHitable, draggable, transform } = model
const { className = '', ...restAttributes } = model.getOuterGAttributes()
Expand All @@ -556,7 +556,7 @@ export abstract class BaseNode<P extends IProps = IProps> extends Component<
)
} else {
if (adjustNodePosition && draggable) {
this.stepDrag.setStep(gridSize * SCALE_X)
this.stepDrag.setStep(gridSize * transformModel.SCALE_X)
}
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still reads the observable transformModel.SCALE_X during render(), so an observer-wrapped node view will continue to track SCALE_X and re-render on every zoom change. Switching from destructuring to transformModel.SCALE_X doesn’t avoid MobX dependency tracking; it only changes when the read occurs.

To actually prevent zoom-triggered node re-renders, avoid reading SCALE_X in render() entirely (e.g., move setStep() into handleMouseDown right before stepDrag.handleMouseDown, or wrap the read in mobx.untracked).

Copilot uses AI. Check for mistakes.
nodeShape = (
<g
Expand Down