Feat recycle rn & wx #1983
Open
Feat recycle rn & wx #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 20, 2025 16:57
hiyuki
reviewed
May 23, 2025
| const extendComponents = {} | ||
| useExtendComponents.forEach((name) => { | ||
| if (mode === 'wx') { | ||
| if (EXTEND_COMPONENTS_LIST.includes(name)) { |
There was a problem hiding this comment.
这个直接维护一个map吧，每个mode支持哪些拓展组件，直接依赖那个map判断就行
hiyuki
reviewed
May 23, 2025
| const extendComponents = {} | ||
| useExtendComponents.forEach((name) => { | ||
| if (EXTEND_COMPONENTS_LIST.includes(name)) { | ||
| extendComponents[name] = require.resolve(`../runtime/components/react/dist/mpx-${name}.jsx`) |
hiyuki
reviewed
May 23, 2025
| { | ||
| style: [{ height, width }, style, layoutStyle], | ||
| data: convertedListData, | ||
| keyExtractor: (item: any, index: number) => item + index, |
hiyuki
reviewed
May 23, 2025
| { | ||
| style: [{ height, width }, style, layoutStyle], | ||
| sections: convertedListData, | ||
| keyExtractor: (item: any, index: number) => item + index, |
hiyuki
reviewed
May 23, 2025
| ), []) | ||
|
|
||
| const renderListHeader = useCallback(() => ( | ||
| <ListHeader listHeaderData={listHeaderData} generichash={generichash} genericlistHeader={genericListHeader}/> |
There was a problem hiding this comment.
这里走callback缓存的话不会重新捕获闭包，数据和jsx片段都不会更新
hiyuki
reviewed
May 23, 2025
| <ListHeader listHeaderData={listHeaderData} generichash={generichash} genericlistHeader={genericListHeader}/> | ||
| ), []) | ||
|
|
||
| const convertToSectionListData = useCallback((data: ListItem[]): Section[] => { |
There was a problem hiding this comment.
这个可以直接扔到下面的useMemo里，能少一个钩子
hiyuki
reviewed
May 23, 2025
| }, [convertedListData]) | ||
|
|
||
| const getItemLayout = useCallback((data: any, index: number) => { | ||
| return itemLayouts[index] |
hiyuki
reviewed
May 23, 2025
| keyExtractor: (item: any, index: number) => item + index, | ||
| renderItem: renderItem, | ||
| getItemLayout: getItemLayout, | ||
| ListHeaderComponent: (generichash && genericListHeader && renderListHeader) || null, |
There was a problem hiding this comment.
getGeneric(generichash, genericListHeader) => GenericComponent
hiyuki
reviewed
Sep 1, 2025
|
|
||
| const getListHeaderComponent = (generichash: string, generickey: string, data: any) => { | ||
| if (!generichash || !generickey) return undefined | ||
| return () => { |
hiyuki
reviewed
Sep 1, 2025
| }, | ||
| mpxGenericRecycleItem: String, | ||
| mpxGenericSectionHeader: String, | ||
| mpxGenericListHeader: String |
There was a problem hiding this comment.
这里为啥需要传递这个，在react的实现里没有看到对应属性
hiyuki
reviewed
Sep 1, 2025
| scrollWithAnimation: { | ||
| type: Boolean, | ||
| value: false | ||
| }, |
There was a problem hiding this comment.
微信下不需要itemHeight之类的吗？但是属性不定义的话会报错吧
hiyuki
reviewed
Sep 1, 2025
|
|
||
| if (mode === 'wx' || mode === 'ali') { | ||
| const { useExtendComponents = {} } = mpx | ||
| if (isApp && useExtendComponents[mode]) { |
There was a problem hiding this comment.
需要考虑非App独立组件输出的场景，以及开个编译配置吧，打开的时候再注入
hiyuki
reviewed
Sep 2, 2025
| scroll-into-view="{{scrollIntoViewId}}" | ||
| scroll-into-view-alignment="{{viewPosition}}" | ||
| > | ||
| <block wx:if="{{mpxGenericListHeader}}"> |
There was a problem hiding this comment.
判断是否存在数据来决定是否渲染对应区域，而不是通过generics
hiyuki
reviewed
Sep 2, 2025
| </sticky-section> | ||
| </block> | ||
| <block wx:else> | ||
| <block wx:if="{{item.itemData && item.itemData.isSectionHeader}}"> |
There was a problem hiding this comment.
和上面对齐都使用item.headerData来定义sectionHeader吧
hiyuki
reviewed
Sep 2, 2025
| ) | ||
| ) | ||
| : createElement( | ||
| FlatList, |
There was a problem hiding this comment.
FlatList中没有使用用户定义的sectionHeader进行渲染
There was a problem hiding this comment.
可以考虑统一使用sectionList进行渲染，通过stickySectionHeadersEnabled控制是否开启sticky效果即可
chore: cr问题修改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.