Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: 修复组件销毁后导致rpx/vw/vh相应式单位失效
现状：当页面上有组件销毁后，屏幕尺寸变化将不会触发使用rpx单位的组件刷新
原因：
del(global.__mpxPageSizeCountMap, pageId)应该在页面销毁时触发，目前在组件销毁时也会触发feat: 输出RN 屏幕尺寸变化时仅刷新依赖rpx/vw/vh响应式单位的组件
目前屏幕尺寸变化时会刷新所有组件，改为仅刷新使用了rpx单位的组件（注: 目前对于css var中使用的rpx无法被检查到，对于存在var中使用rpx，但又未使用普通的rpx单位的组件可能无法在屏幕尺寸变化时刷新）
fix: 修复输出RN externalClasses 变化时未触发组件render
现状：父亲组件修改传入的 externalClasses 值后，子组件未刷新
原因：目前传入的 externalClasses 属性值不具有相应式
修复方式：
1. 将externalClasses配置保留到运行时，将其添加到validProps中使其与普通props一样具有相应式
2. 在 __getStyle 中从原本的this.__props[className]改为从this.__mpxProxy.props[className]获取externalClasses的值，使其与响应式数据形成关联。