-
Notifications
You must be signed in to change notification settings - Fork 49
Dev create tests #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev create tests #394
Conversation
added a test for create fusion tab builder
Adds a test that verifies that the manual fusion tab in OnkoDICOM: Loads correctly with the expected widgets and controls, Allows interaction with the fusion controls (translation, rotation, color, opacity), And that the main fusion views (axial, sagittal, coronal, single) are present and functional.
split the test up into multiple so that if one fails its easier to narrow down
Added more tests to test the widgets / buttons and everything loads and works with manual fusion load.
Added a test to see if the VTK engine is there Added a test that tests to see if the moving image and fixed image loads from the vtk engine Note: still need to get rid of the debugs
Made tests views image fusion less complicated and got rid of the GUI trhings it now just tests if the vtk engine gets the fixed and overlay and can load them added more info about the tests to both of them
Moved things around to make neater and deleted a line from a docstring
Reviewer's GuideThis PR introduces a comprehensive test suite for the image fusion feature, covering GUI-level behaviors in the manual fusion tab, engine- and loader-level logic tests for DICOM loading and fusion infrastructure, and builder tests to verify the construction of the fusion tab. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a skip for CI / workflow because the dialog box would require interaction and it could be creating a time out in the workflow added a new test for CI that just tests to see if the save and load buttons are there and doesnt interact with it
Update to fix method that looks for 2 directories in the test folder. As image fusion needs two but there is not in there we needed to just get it to resuse the same directory for moving and fixed images
Updated tests to add a patient container.clear() so these tests dont contaminate other test
Testing by commenting out code to see which tests messes with the rest of the tests
Tests were failing because this test modified and changed files if there was only one directory in tests. But as manual fusion requires 2, i previously tried to make it use the same directory twice. Added a skip instead if there is only one directory
This test kept failing so im taking it out for now
AJB-BigA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Kahreiru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues with these.
Out of curiosity, how does the testing of the GUI work with the runner being headless I assume you don't actually open the window.
Tests added
test_manual_fusion_tab
These tests verify that:
Test_manual_fusion_tab_builder
This mock class records calls to setup methods and simulates the attributes and methods
expected by the ImageFusionTabBuilder. It is used to verify that the builder interacts
with the main window as expected during tab construction.
test_view_manula_fusion
Tests for OnkoDICOM's image fusion infrastructure.
These tests verify that:
No GUI is launched; these are logic and engine-level tests only.
Summary by Sourcery
Add comprehensive tests for OnkoDICOM's image fusion functionality, covering GUI manual fusion tab, backend fusion logic, and tab builder integration.
Tests: