Skip to content

Conversation

@Kahreiru
Copy link
Collaborator

@Kahreiru Kahreiru commented Oct 16, 2025

This seemed to have worked on my first run of tests.
Not a good fix but it seemed to avoid the Seg Fault.
Probably need to look in to rewriting this group of tests.

Summary by Sourcery

Work around a segmentation fault in test_model_configuration by disabling the existing tests and marking them for future revision

Bug Fixes:

  • Temporarily comment out all tests in test_model_configuration.py to prevent the segfault

Enhancements:

  • Change the init_sqlite_config fixture scope from function to module (commented out)

Tests:

  • Adjust the inserted record ID in the test_get_default_directory test (commented out)

Chores:

  • Add TODO comments to highlight that the tests need to be rewritten and uncommented

@Kahreiru Kahreiru self-assigned this Oct 16, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 16, 2025

Reviewer's Guide

This PR circumvents a segfault in the configuration tests by commenting out the entire test suite, temporarily adjusting the pytest fixture scope, tweaking a test data ID, and adding a TODO note to revisit and properly rewrite these tests.

File-Level Changes

Change Details Files
Entire test suite disabled via comments
  • All import statements and test definitions are prefixed with '#'
  • Original pytest fixture and test functions are commented out
  • Introduced commented-out alternative fixture block
test/test_model_configuration.py
Temporarily change fixture scope
  • Modified pytest.fixture scope from function to module (commented)
  • Removed autouse to isolate test module
test/test_model_configuration.py
Test data ID updated
  • Changed inserted configuration ID from 1 to 2 in test_get_default_directory
test/test_model_configuration.py
Added TODO for test rewrite
  • Inserted TODO note prompting review and rewriting of this test group
test/test_model_configuration.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Kahreiru Kahreiru closed this Oct 20, 2025
@Kahreiru Kahreiru deleted the segFaultIssue branch October 20, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant