-
Notifications
You must be signed in to change notification settings - Fork 49
I made a mistake and now fixing it #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusted the instantiation of SegmentSelectorWidget to match the updated constructor signature by removing the unnecessary parent widget argument. Class diagram for updated SegmentSelectorWidget instantiationclassDiagram
class AutoSegmentWindow {
- _view_state: AutoSegmentViewState
- _tree_selector: SegmentSelectorWidget
- _start_button: QtWidgets.QPushButton
- _progress_text: QtWidgets.QTextEdit
}
class SegmentSelectorWidget {
+ __init__(segmentation_list, update_callback)
}
AutoSegmentWindow --> SegmentSelectorWidget : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nowhere4Nothing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve
Timmy-Codes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by Sourcery
Bug Fixes: