fix(cli): detect npm-global Claude .cmd shims under Program Files on Windows - #12565
Open
drmikecrypto wants to merge 1 commit into
Open
fix(cli): detect npm-global Claude .cmd shims under Program Files on Windows#12565drmikecrypto wants to merge 1 commit into
drmikecrypto wants to merge 1 commit into
Conversation
diegosouzapw#12563) Stock Node MSI installs drop claude.cmd there, but detection never listed that directory and Electron's PATH often omits it, so the dashboard reported settings_found_binary_unresolved while a normal shell could run the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12563.
On a stock Windows Node MSI, npm-global Claude lands as C:\Program Files\nodejs\claude.cmd. That directory was already trusted for containment, but getKnownToolPaths never looked there. Electron often inherits a PATH without it, so where.exe misses the shim and the dashboard reports settings_found_binary_unresolved.
Different hole than #7831 / #7774 (.ps1 / known-path short-circuit).
What changed
Test plan