fix(sse): strip Codex temperature on native Responses passthrough - #12585
Open
fouadSalkini wants to merge 1 commit into
Open
fix(sse): strip Codex temperature on native Responses passthrough#12585fouadSalkini wants to merge 1 commit into
fouadSalkini wants to merge 1 commit into
Conversation
Codex /responses rejects sampling params with FastAPI 400 Unsupported parameter: temperature. Native passthrough returned before the Responses allowlist, so client temperature reached upstream on combo traffic. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/responses(chatgpt.com) rejects sampling params with FastAPI{"detail":"Unsupported parameter: temperature"}. Combocodex-reviewforwarded clienttemperature/top_pontogpt-5.6-sol-xhigh/gpt-5.6-luna-maxbecause native Responses passthrough returns before the Responses allowlist.STRIP_RULESentry and callstripUnsupportedParams("codex", …)inCodexExecutor.transformRequestnext to the existing#3317client-only field strip (user,prompt_cache_retention,safety_identifier).#3317passthrough test andstripUnsupportedParamsunit tests so this cannot regress.Test plan
node --import tsx/esm --test tests/unit/codex-responses-passthrough-strip-3317.test.ts tests/unit/executors-strip-unsupported-params.test.ts(28/28)codex-reviewturn that previously 400'd ontemperature(new Codex turn, not a 409-pinned retry)Made with Cursor