Add run_pending_migrations_in_range and revert_last_migrations_in_range #4886
+75
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
requested changes
Dec 1, 2025
Member
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
Thanks for opening this PR. I think this is a good addition to diesel_migrations. Before merging I would like to address the minor style nits I've put comments on and also I would like to see:
- A changelog entry
- At least a test for each new method
| /// Controls the amount of migrations that are run or reverted | ||
| #[derive(Debug, Hash, PartialEq, Eq)] | ||
| #[non_exhaustive] | ||
| pub enum Range { |
Member
There was a problem hiding this comment.
Suggested change
| pub enum Range { | |
| pub enum MigrationRange { |
to avoid collisions with the Range type from the stdlib.
Comment on lines
+59
to
+63
| fn run_pending_migrations_in_range<S: MigrationSource<DB>>( | ||
| &mut self, | ||
| source: S, | ||
| range: &Range, | ||
| ) -> Result<Vec<MigrationVersion<'_>>> { |
Member
There was a problem hiding this comment.
Suggested change
| fn run_pending_migrations_in_range<S: MigrationSource<DB>>( | |
| &mut self, | |
| source: S, | |
| range: &Range, | |
| ) -> Result<Vec<MigrationVersion<'_>>> { | |
| fn run_pending_migrations_in_range( | |
| &mut self, | |
| source: impl MigrationSource<DB>, | |
| range: &Range, | |
| ) -> Result<Vec<MigrationVersion<'_>>> { |
Comment on lines
+105
to
+109
| fn revert_last_migrations_in_range<S: MigrationSource<DB>>( | ||
| &mut self, | ||
| source: S, | ||
| range: &Range, | ||
| ) -> Result<Vec<MigrationVersion<'_>>> { |
Member
There was a problem hiding this comment.
Suggested change
| fn revert_last_migrations_in_range<S: MigrationSource<DB>>( | |
| &mut self, | |
| source: S, | |
| range: &Range, | |
| ) -> Result<Vec<MigrationVersion<'_>>> { | |
| fn revert_last_migrations_in_range( | |
| &mut self, | |
| source: impl MigrationSource<DB>, | |
| range: &Range, | |
| ) -> Result<Vec<MigrationVersion<'_>>> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the code for running a specific number of migrations is now in the diesel_migrations library instead of diesel_cli, so it can be used by a custom migration CLI. There's now a lot less code in diesel_cli, and a custom migration CLI would be similarly affected.
In the future, variant(s) like
Range::StopBefore(MigrationVersion)could be added to allow reverting to a specific version of the schema without manually counting the number of migrations to revert.