Open
Conversation
demhadais
commented
Feb 26, 2026
- implement at least postgres deserialization and serialization of an enum type
- basically complete the implementation
- partial commit
- turns out the function was done. just remove the unnecessary lines of code
- rename the derive-macro to something a bit simpler. I'm not sure if this is good though. Also, write documentation. Also, write two simple tests
- add a test that actually tries inserting the color into the database
- remove failing test
- give parsed_backends set explicit capacity
- implement FromSql and ToSql for generated types, not Text
- fix syntax for repeating elements
- add as_expression and fromsqlrow impls
- try to make the test work by using the derive correctly
- fix test helper code
- add sql_type to allowed parsing. I anticipate this will have to be reworked a bit
- fix clippy and formatting recommendations
- try to rely on the already implemented check-for-backend functionality to make it work
- revert the rust tooclhain to fix the conflict
- remove custom attribute and just use the model parsing because it's there
- gate the enum test behind a feature to make it work
…his is good though. Also, write documentation. Also, write two simple tests
…y to make it work
This is an incomplete pull request, but I am merging into my local fork to get updates from the upstream.
Author
|
@weiznich Sorry this took so long, but just pinging you because I had a draft PR that I closed, and I haven't worked on this in a long time. Anyways, this implements the first step of #4759. The tests are super basic, and I'm happy to add more, but I couldn't think of any meaningful tests that aren't redundant with other tests in the codebase. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.