Skip to content

CONTRACTS: Add inductive checks for assigns clauses [depends-on: #7127] #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

qinheping
Copy link
Collaborator

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Fixes #7208

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 78.50% // Head: 78.28% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (4f9b5cc) compared to base (3f578e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4f9b5cc differs from pull request most recent head ae04f0d. Consider uploading reports for the commit ae04f0d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7300      +/-   ##
===========================================
- Coverage    78.50%   78.28%   -0.23%     
===========================================
  Files         1663     1642      -21     
  Lines       191297   189988    -1309     
===========================================
- Hits        150174   148728    -1446     
- Misses       41123    41260     +137     
Impacted Files Coverage Δ
...oto-instrument/contracts/instrument_spec_assigns.h 94.73% <ø> (ø)
src/goto-instrument/havoc_utils.cpp 100.00% <ø> (ø)
src/goto-instrument/havoc_utils.h 100.00% <ø> (ø)
src/goto-instrument/contracts/contracts.cpp 95.07% <100.00%> (-0.47%) ⬇️
...o-instrument/contracts/instrument_spec_assigns.cpp 99.39% <100.00%> (+<0.01%) ⬆️
src/goto-programs/name_mangler.cpp 50.00% <0.00%> (-50.00%) ⬇️
src/solvers/flattening/pointer_logic.h 72.72% <0.00%> (-27.28%) ⬇️
src/goto-symex/solver_hardness.cpp 59.00% <0.00%> (-16.63%) ⬇️
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 73.22% <0.00%> (-16.32%) ⬇️
src/util/invariant.h 82.22% <0.00%> (-13.34%) ⬇️
... and 615 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feliperodri feliperodri changed the title CONTRACTS: add inductive checks for assigns clauses CONTRACTS: Add inductive checks for assigns clauses Nov 7, 2022
@feliperodri feliperodri added bugfix aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Nov 8, 2022
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would benefit from a rebase to make CI pass all checks.

Comment on lines -34 to -42
if(expr.id() == ID_index || expr.id() == ID_dereference)
{
address_of_exprt address_of_expr(expr);
if(!is_constant(address_of_expr))
{
append_object_havoc_code_for_expr(location, address_of_expr, dest);
return;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate if the commit message could explain why this change is needed here/is the right thing to do.

@qinheping qinheping changed the title CONTRACTS: Add inductive checks for assigns clauses CONTRACTS: Add inductive checks for assigns clauses [depends-on: #7127] Nov 9, 2022
@feliperodri feliperodri closed this Apr 3, 2023
@qinheping qinheping deleted the loop-contract branch October 18, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users bugfix Code Contracts Function and loop contracts dependent - do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement inductive check for assigns clauses in loop contracts
3 participants