Skip to content

Xml description addition #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Xml description addition #6237

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c06afa
Output description in XML
TGWDB Jul 20, 2021
0b88930
Fix regression test using XML output
TGWDB Jul 20, 2021
624743d
Update XML schema to allow description in results
TGWDB Jul 20, 2021
6f521a4
Skip tests that display unprintable characters in XML
TGWDB Jul 20, 2021
cb2457b
Add KNOWNBUG regression test for printing special operators
TGWDB Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions regression/cbmc/xml-interface1/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ CORE
^EXIT=10$
^SIGNAL=0$
Not unwinding loop foo\.0 iteration 3 file main\.c line 5 function foo thread 0
<result property="foo\.assertion\.3" status="SUCCESS"/>
<result property="foo\.assertion\.1" status="FAILURE">
<result description="assertion 0" property="foo\.assertion\.3" status="SUCCESS"/>
<result description="assertion 0" property="foo\.assertion\.1" status="FAILURE">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: I'd prefer for this commit to be merged with prior commit that causes this test to break. Just makes any future bisecting easier.

<goto_trace>
VERIFICATION FAILED
--
Expand Down
1 change: 1 addition & 0 deletions src/goto-checker/properties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ xmlt xml(const irep_idt &property_id, const property_infot &property_info)
xmlt xml_result("result");
xml_result.set_attribute("property", id2string(property_id));
xml_result.set_attribute("status", as_string(property_info.status));
xml_result.set_attribute("description", as_string(property_info.description));
return xml_result;
}

Expand Down