Skip to content

Support byte update lowering of/from an array of bits [depends-on: #6488] #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tautschnig
Copy link
Collaborator

Byte operator lowering made several assumptions about array elements
being byte aligned, which may be true for ANSI C, but isn't the case for
our C front-end (which supports arrays of single bits), and not true for
the overall framework in general.

A key part of this is factoring out code that was almost-the-same from
lower_byte_update_array_vector and lower_byte_update_struct.

Depends on #6488 for tests to pass.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 29, 2021
@tautschnig tautschnig changed the title Support byte update lowering of/from an array of bits Support byte update lowering of/from an array of bits [depends-on: #6488] Nov 29, 2021
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with #6488 PLEASE can we have some very extensive testing?

@tautschnig tautschnig force-pushed the byte-update-bits branch 2 times, most recently from fe2f577 to 8bfd3aa Compare October 23, 2022 20:23
@tautschnig tautschnig force-pushed the byte-update-bits branch 2 times, most recently from 9922c22 to b5fb09b Compare November 14, 2022 09:04
Byte operator lowering made several assumptions about array elements
being byte aligned, which may be true for ANSI C, but isn't the case for
our C front-end (which supports arrays of single bits), and not true for
the overall framework in general.

A key part of this is factoring out code that was almost-the-same from
lower_byte_update_array_vector and lower_byte_update_struct.
@tautschnig
Copy link
Collaborator Author

Closing in favour of #7855.

@tautschnig tautschnig closed this Sep 18, 2023
@tautschnig tautschnig deleted the byte-update-bits branch September 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants