Skip to content

C library: atexit #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

C library: atexit #6604

wants to merge 7 commits into from

Conversation

tautschnig
Copy link
Collaborator

atexit introduces function calls that may affect the verification outcome.

Only the last commit is new, all other commits have PRs of their own.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 21, 2022
tautschnig and others added 7 commits January 21, 2022 14:02
@tautschnig
CBMC library regression tests: ensure GNUC-only declarations are present
c2890b4 
MSVC won't have the built-in declarations available, and will thus fail
type checking.
@tautschnig @peterschrammel
Use the linker when adding library functions
8d6aa14 
This enables type checking of missing functions vs library-provided functions,
and also enables type sanitisation as done by the linker.

Co-authored-by: Peter Schrammel <[email protected]>
@tautschnig
C library: move pipe() related definitions to library
bcfe0c8 
With the support of building initialisers while adding the library we
can move library-only symbols to the library. This avoids polluting the
initialisation function for all cases that don't actually use
pipe-related library functions.
@tautschnig
C/C++ library: move free/delete-only definitions to library
f877629 
With the support of building initialisers while adding the library we
can move library-only symbols to the library. This avoids polluting the
initialisation function for all cases that don't actually use
memory (de-)allocation library functions.
@tautschnig
C library: move pthreads related definitions to library
c3f5f03 
With the support of building initialisers while adding the library we
can move library-only symbols to the library. This avoids polluting the
initialisation function for all cases that don't actually use
pthreads-related library functions.

This removal of unused symbols required adding a symbol into the
array_of_bool_as_bitvec test, which previously implicitly relied on
those library-specific symbols in the patterns being tested for.
@tautschnig
Invoke functions marked __attribute__((destructor))
dcdf046 
This is a GCC extension that our front-end parses, but an implementation
of the desired semantics was hitherto missing.
@tautschnig
C library: atexit
8edaf8e 
atexit introduces function calls that may affect the verification
outcome.
@tautschnig tautschnig changed the title C library: atexit C library: atexit [depends-on: #6590] Nov 9, 2022
@tautschnig tautschnig changed the title C library: atexit [depends-on: #6590] C library: atexit Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening Awaiting requested review from kroening kroening will be requested when the pull request is marked ready for review kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs will be requested when the pull request is marked ready for review martin-cs is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 will be requested when the pull request is marked ready for review remi-delmas-3000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tautschnig tautschnig

Labels
C Front End Needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tautschnig