Skip to content

Remove support for __CPROVER_allocated_memory [depends-on: #6747] #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Remove support for __CPROVER_allocated_memory [depends-on: #6747] #6748

wants to merge 2 commits into from

Conversation

tautschnig
Copy link
Collaborator

With the --mmio-regions command-line option it is no longer necessary to be able specify readable/writable memory regions in source code.

This depends on #6747. Labelled "Version 6" as this may break existing uses.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
New option --mmio-regions to specify memory regions
ac2eaf3 
This new option will enable us to eventually drop support for
__CPROVER_allocated_memory, which
1) requires awkward scanning of goto functions in goto_check_c,
2) wrongly suggests these declarations are limited to some scope, and
3) yields a spurious undefined-function warning in symex.
@tautschnig
Remove support for __CPROVER_allocated_memory
f22d2e8 
With the --mmio-regions command-line option it is no longer necessary to
be able specify readable/writable memory regions in source code.
@tautschnig tautschnig added the Version 6 Pull requests and issues requiring a major version bump label Mar 23, 2022
@tautschnig tautschnig self-assigned this Mar 23, 2022
@tautschnig tautschnig changed the title Remove support for __CPROVER_allocated_memory Remove support for __CPROVER_allocated_memory [depends-on: #6747] Mar 25, 2022
@thomasspriggs thomasspriggs mentioned this pull request May 19, 2022
Closed
@tautschnig tautschnig mentioned this pull request Jan 3, 2023
Closed
@esteffin esteffin mentioned this pull request Nov 8, 2023
Open
5 tasks
@tautschnig tautschnig added Version 7 and removed Version 6 Pull requests and issues requiring a major version bump labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroening kroening Awaiting requested review from kroening kroening will be requested when the pull request is marked ready for review kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel will be requested when the pull request is marked ready for review peterschrammel is a code owner

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 will be requested when the pull request is marked ready for review remi-delmas-3000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tautschnig tautschnig

Labels
dependent - do not merge Property Instrumentation Version 7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tautschnig