Skip to content

New pointer encoding #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

New pointer encoding #6832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed2a9fa
bv_utilst::sign_extension, zero_extension and zeros can be static
kroening Apr 26, 2022
1ba8148
new pointer encoding
kroening Apr 26, 2022
b08c997
pointer encoding: tests changed
kroening Apr 27, 2022
6f42b0e
re-encode integers converted to pointers
kroening Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc-json-ui/pointer-simplification/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
test
filter.jq --json-ui --trace
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc-strings/StringFormatHex/test-hex-eval-upper.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test
--function Test.testHexEvalUpper --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar` --trace
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc-strings/StringFormatHex/test-hex-eval.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test
--function Test.testHexEval --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar` --trace
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc-strings/char_escape/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test
--function Test.test --trace --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar` --json-ui
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/address_space_size_limit1/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test
--object-bits 4
too many addressed objects
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/assume-inputs-non-null/class_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
My
--function My.classArg --java-assume-inputs-non-null
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/lambda-boxing/Boolean.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
BoxingLambda
--function BoxingLambda.testBoolean --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar`
\[java::BoxingLambda\.testBoolean:\(\)V\.assertion\.1\] line 73 assertion at file BoxingLambda\.java line 73 function java::BoxingLambda\.testBoolean:\(\)V bytecode-index 25: SUCCESS
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/lambda-boxing/Float.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
BoxingLambda
--function BoxingLambda.testFloat --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar`
\[java::BoxingLambda\.testFloat:\(\)V\.assertion\.1\] line 125 assertion at file BoxingLambda\.java line 125 function java::BoxingLambda\.testFloat:\(\)V bytecode-index 27: SUCCESS
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/lambda-boxing/Integer.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
BoxingLambda
--function BoxingLambda.testInteger --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar`
\[java::BoxingLambda\.testInteger:\(\)V\.assertion\.1\] line 138 assertion at file BoxingLambda\.java line 138 function java::BoxingLambda\.testInteger:\(\)V bytecode-index 26: SUCCESS
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/lambda-void-return-type/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test
--function Test.test --classpath `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar`
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/no-main-args-elements-maybe-null2/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Main
--function Main.main
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/jbmc/string_field_aliasing/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Cart
--cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar` --trace --java-max-vla-length 96 --java-unwind-enum-static --max-nondet-string-length 200 --unwind 4 --function Cart.checkTax4 --string-printable
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion jbmc/regression/strings-smoke-tests/java_parseint/test4.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
Test4
--max-nondet-string-length 1000 --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar ../../../lib/java-models-library/target/cprover-api.jar` --function Test4.main --trace
^EXIT=10$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-library/free-01/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CORE
main.c
--pointer-check --bounds-check --stop-on-fail
free argument must be NULL or valid pointer
free argument must be (dynamic object|NULL or valid pointer)
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-primitives/r_w_ok_bug/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
main.c
--pointer-check --no-simplify --no-propagation
^\[main.pointer_dereference.\d+\] line 8 dereference failure: pointer outside object bounds in \*p1: FAILURE$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-primitives/same-object-01/test-no-cp.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
main.c
--no-simplify --no-propagation
^EXIT=0$
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc-primitives/same-object-01/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
main.c

^EXIT=0$
Expand Down
3 changes: 1 addition & 2 deletions regression/cbmc/Pointer_comparison1/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ int main()
return 0;

if(
(unsigned long)p >
42) // unsoundly evaluates to true due to pointer encoding
(unsigned long)p > 1) // unsoundly evaluates to true due to pointer encoding
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion regression/cbmc/address_space_size_limit1/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE thorough-paths broken-smt-backend
KNOWNBUG thorough-paths broken-smt-backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the "address_space_size_limit*" tests should simply be removed as part this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.

test.c
--no-simplify --unwind 300 --object-bits 8
too many addressed objects
Expand Down
1 change: 1 addition & 0 deletions regression/cbmc/hex_trace/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ int main()
char *p;

a = 0;
b = 0;
a = -100;
a = 2147483647;
b = a * 2;
Expand Down
2 changes: 1 addition & 1 deletion regression/contracts/assigns-enforce-malloc-zero/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
main.c
--enforce-contract foo _ --malloc-may-fail --malloc-fail-null
^\[foo.assigns.\d+\] line 9 Check that POINTER_OBJECT\(\(const void \*\)a\) is valid when a != \(\(char \*\)NULL\): SUCCESS$
Expand Down
2 changes: 1 addition & 1 deletion regression/contracts/test_struct_member_enforce/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CORE
KNOWNBUG
main.c
--enforce-contract foo
^EXIT=0$
Expand Down
Loading