Enable compact less-than propositional encoding #7068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
feature/enable-compact-le-or-lt
branch
from
f620635 to
40a5d86
Compare
tautschnig
requested review from
martin-cs,
kroening and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7068 +/- ##
===========================================
- Coverage 77.86% 77.85% -0.01%
===========================================
Files 1569 1569
Lines 180995 181038 +43
===========================================
+ Hits 140929 140951 +22
- Misses 40066 40087 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
martin-cs
approved these changes
Aug 13, 2022
tautschnig
force-pushed
the
feature/enable-compact-le-or-lt
branch
2 times, most recently
from
9a13304 to
8afeaca
Compare
This was previously disabled as it appeared to degrade performance. New benchmarking, however, suggests considerable performance improvement: When running on various proofs done for AWS open-source projects, this changes the performance as follows (when comparing to diffblue#7021): with CaDiCaL as back-end, the total solver time for the hardest 46 proofs changes from 26779.7 to 24472.6 seconds (2307.1 seconds speed-up); with Minisat the hardest 49 proofs take 18541.2 instead of 28420.4 seconds (9879.2 seconds speed-up). Across these benchmarks, 1.0% of variables and 3.2% of clauses are removed. INCLUDE_REDUNDANT_CLAUSES is not enabled: while this would yield a further speed-up of 1080.4 seconds with CaDiCaL, it slows down Minisat by 4440.6 seconds on the above benchmark set.
tautschnig
force-pushed
the
feature/enable-compact-le-or-lt
branch
from
8afeaca to
3cd6348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously disabled as it appeared to degrade performance. New
benchmarking, however, suggests considerable performance improvement:
When running on various proofs done for AWS open-source projects, this
changes the performance as follows (when comparing to #7021): with
CaDiCaL as back-end, the total solver time for the hardest 46 proofs
changes from 26779.7 to 24472.6 seconds (2307.1 seconds speed-up); with
Minisat the hardest 49 proofs take 18541.2 instead of 28420.4
seconds (9879.2 seconds speed-up). Across these benchmarks, 1.0% of
variables and 3.2% of clauses are removed.