introduce __CPROVER_map type #7096
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7096 +/- ##
===========================================
+ Coverage 77.85% 77.86% +0.01%
===========================================
Files 1574 1576 +2
Lines 181245 181541 +296
===========================================
+ Hits 141109 141358 +249
- Misses 40136 40183 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Could we please include some documentation of this, especially as there also is an intent to deprecate existing functionality? |
|
Also, could we please have some tests? |
|
Hi, some questions regarding the feature:
Thanks |
kroening
force-pushed
the
map_type
branch
3 times, most recently
from
5b58406 to
f718eb4
Compare
Using a lambda.
It's a function, so
DECL only. These do not have an in-memory representation.
No. But you can have maps of maps.
It's the existing Ackermann reduction. |
kroening
force-pushed
the
map_type
branch
2 times, most recently
from
82f715e to
48e4eb8
Compare
tautschnig
approved these changes
Jan 8, 2025
regression/cbmc/map-type/basic1.desc
Outdated
Comment on lines
1
to
6
| CORE | ||
| basic1.c | ||
|
|
||
| ^EXIT=0$ | ||
| ^SIGNAL=0$ | ||
| ^VERIFICATION SUCCESSFUL$ |
There was a problem hiding this comment.
Somewhat random place for comment: I'd also like to see a failing test.
| @@ -2534,6 +2534,7 @@ void c_typecheck_baset::typecheck_side_effect_function_call( | |||
| function_application_exprt function_application(f_op, expr.arguments()); | |||
|
|
|||
| function_application.add_source_location() = expr.source_location(); | |||
| function_application.type() = mathematical_function_type.codomain(); | |||
There was a problem hiding this comment.
Was this a bug? Did we not bump into this before?
| { | ||
| const mathematical_function_typet &function_type = | ||
| to_mathematical_function_type(src); | ||
| std::string dest = CPROVER_PREFIX "map("; |
There was a problem hiding this comment.
Is this really the only case of a mathematical function?
regression/cbmc/map-type/basic1.c
Outdated
Comment on lines
5
to
13
| my_map = __CPROVER_lambda | ||
| { | ||
| int i; | ||
| i == 1 ? 10 : 20 | ||
| }; | ||
|
|
||
| __CPROVER_assert(my_map(1) == 10, "(1)"); | ||
| __CPROVER_assert(my_map(2) == 20, "(2)"); |
There was a problem hiding this comment.
- Can one also use assumptions to have values in a map?
- Is there any (other) way to incrementally populate a map?
This introduces C syntax for a type __CPROVER_map(domain, codomain) where domain is a list of types and codomain is a type. The type is internal, for modeling purposes within our own library only, and hence not added to user-facing documentation. It replaces arrays with size __CPROVER_infinity, which are now deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces C syntax for a type
__CPROVER_map(domain,codomain)where domain is a list of types and codomain is a type. The type is
internal, for modeling purposes. It replaces arrays with size
__CPROVER_constant_infinity_uint, which are now deprecated.