Linking: fix up all types before handling functions or objects

[tautschnig]

Function parameters may require application of type fixes: our linking ensures that all types have a unique tag, and some parameter's types may require such tag updates. We used to do this for objects already, but need to apply it to parameters as well. Also, the order matters: all types need to be sorted out first before attempting objects or functions.

Spotted while trying to compile a particular version of Xen 4.11.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.47%. Comparing base (6aeace1) to head (79cf301).
Report is 1 commits behind head on develop.

❗ Current head 79cf301 differs from pull request most recent head fe5c1a1. Consider uploading reports for the commit fe5c1a1 to get more accurate results

Files	Patch %	Lines
src/linking/linking.cpp	94.44%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7579      +/-   ##
===========================================
+ Coverage    78.23%   78.47%   +0.24%     
===========================================
  Files         1720     1670      -50     
  Lines       188342   191778    +3436     
  Branches     18442        0   -18442     
===========================================
+ Hits        147353   150503    +3150     
- Misses       40989    41275     +286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harmim]

It seems this fixed my problem with building Xen 4.11. Thanks @tautschnig.