C front-end: tolerate type differences with asm renaming #7584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example found in glibc shows how asm renaming may be combined with changes in return type names (even when there isn't actually a bit-level difference amongst the types). Weakening the asm-renamed declaration by marking it "incomplete" works around this problem.
tautschnig
requested review from
chris-ryder,
peterschrammel and
remi-delmas-3000
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7584 +/- ##
===========================================
+ Coverage 78.36% 78.50% +0.14%
===========================================
Files 1670 1670
Lines 191768 191770 +2
===========================================
+ Hits 150277 150551 +274
+ Misses 41491 41219 -272
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
assigned tautschnig and unassigned kroening, remi-delmas-3000 and peterschrammel
TGWDB
approved these changes
Mar 13, 2023
peterschrammel
approved these changes
Mar 27, 2023
| @@ -646,6 +646,8 @@ void c_typecheck_baset::apply_asm_label( | |||
| { | |||
| symbol.name=asm_label; | |||
| symbol.base_name=asm_label; | |||
| if(symbol.type.id() == ID_code) | |||
There was a problem hiding this comment.
An explaining comment would be great here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example found in glibc shows how asm renaming may be combined with changes in return type names (even when there isn't actually a bit-level difference amongst the types). Weakening the asm-renamed declaration by marking it "incomplete" works around this problem.