Value sets: make pointers nondet only once #7716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7716 +/- ##
===========================================
+ Coverage 78.66% 78.69% +0.02%
===========================================
Files 1699 1699
Lines 194181 194219 +38
===========================================
+ Hits 152757 152835 +78
+ Misses 41424 41384 -40
☔ View full report in Codecov by Sentry. |
This was referenced May 19, 2023
tautschnig
force-pushed
the
cleanup/nondet-pointer-perf
branch
from
ed337e2 to
4833a24
Compare
|
I have now added a second commit that replaces the use of |
peterschrammel
approved these changes
Jul 11, 2023
When `get_value_set_rec` discovers a nondet symbol it will consider the pointer pointing to any of the known objects (as of 3789670). It suffices to do this once for each run of `get_value_set`, even when multiple nondet symbols are encountered while traversing an expression. This reduces the symex time on the test of diffblue#7357 from 930 seconds to 404 seconds.
There is no change in behaviour here, just cleanup to avoid a use of `mutable` that was only put in place to keep the code churn to a minimum.
tautschnig
force-pushed
the
cleanup/nondet-pointer-perf
branch
from
4833a24 to
88dd798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
get_value_set_recdiscovers a nondet symbol it will consider the pointer pointing to any of the known objects (as of 3789670). It suffices to do this once for each run ofget_value_set, even when multiple nondet symbols are encountered while traversing an expression.This reduces the symex time on the test of #7357 from 930 seconds to 404 seconds.
RFC: The initial implementation is done so as to be keep the change as small as possible. We will want to explore variants that avoid the use ofmutable.