Additional forward propagation to aid code contracts #7737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tautschnig
commented
May 29, 2023
tautschnig
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Rather than adding more-and-more expressions to the enumeration just call out those that are _not_ constant ((nondet) symbols and side-effect expressions as well as any access that may be out of bounds).
We would only deem with_exprt constant when all their operands are constant, which means that the array operand must be an array or array_of expression, and both update indices as well as update values must be constant. In most such cases the simplifier would rewrite the with_exprt anyway. The exception to this is an index that cannot immediately be evaluated to a numeric constant, as is the case with, e.g., pointer_object expressions. Fixes: diffblue#3095
We do not prescribe a fixed type for these expressions, so we can just alter the type and have back-ends deal with producing a suitable value of the new type. Co-authored-by: Remi Delmas <[email protected]>
Needs some heuristics to constrain `record_may_leak`, which can produce deeply nested expressions. Co-authored-by: Remi Delmas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.