Skip to content

skpkg: run package update for skpkg 0.3.0#164

Merged
sbillinge merged 29 commits intodiffpy:v3.3.0from
cadenmyers13:update030
Feb 26, 2026
Merged

skpkg: run package update for skpkg 0.3.0#164
sbillinge merged 29 commits intodiffpy:v3.3.0from
cadenmyers13:update030

Conversation

@cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Feb 25, 2026

Added a new copyright,

2026-present, The DiffPy team

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review. Looks like pre-commit was out of date a bit too so some pre-commit edits were made by the bot

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.36%. Comparing base (fc672df) to head (cee67de).
⚠️ Report is 31 commits behind head on v3.3.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.3.0     #164   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files          25       25           
  Lines        3832     3832           
=======================================
  Hits         2773     2773           
  Misses       1059     1059           
Files with missing lines Coverage Δ
tests/conftest.py 91.89% <ø> (ø)
tests/test_contribution.py 99.58% <ø> (ø)
tests/test_fitrecipe.py 99.83% <ø> (ø)
tests/test_objcrystparset.py 10.27% <ø> (ø)
tests/test_profilegenerator.py 97.95% <ø> (ø)
tests/test_sgconstraints.py 10.06% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

please see inline comment

please check if there are any CI workflows that need to be deleted, replaced with the new ones here.

# See LICENSE.rst for license information.
#
##############################################################################
"""Complex modeling framework for structure refinement and solution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check, do we want to lose this text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge we are moving to just having the brief description here. I moved this to the README (A better place for it to live imo)

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Feb 25, 2026

please check if there are any CI workflows that need to be deleted, replaced with the new ones here.

@sbillinge good catch, thanks!

This is failing pre-commit docformatting, I think maybe because of this merge #165 ? Not sure though

Can we merge this first, then i'll figure out whats causing this to fail?

@cadenmyers13
Copy link
Contributor Author

This is failing pre-commit docformatting, I think maybe because of this merge #165 ? Not sure though

@sbillinge confirmed, it is because of this. I merged from upstream. Now its passing!

@sbillinge sbillinge merged commit 0ef0ed0 into diffpy:v3.3.0 Feb 26, 2026
6 checks passed
@cadenmyers13 cadenmyers13 deleted the update030 branch February 26, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants