fix: add three dependencies to conda to ensure correct build#40
Merged
sbillinge merged 7 commits intodiffpy:mainfrom Nov 25, 2025
Merged
fix: add three dependencies to conda to ensure correct build#40sbillinge merged 7 commits intodiffpy:mainfrom
sbillinge merged 7 commits intodiffpy:mainfrom
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
|
please check that there is an issue attached to this release to re-add |
Contributor
Author
|
@sbillinge Right now the CI test will fail because we still not release |
Collaborator
|
@sbillinge I think this can be merged now. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review, note that this is a fix to the conda-forge release build, currently because do not have three dependencies so it could not correctly build on conda-forge staged recipe. So, after merge this I think we also need to redo the pre-release step.