Chore: Convert variables to lowercase#157
Chore: Convert variables to lowercase#157john-halloran wants to merge 2 commits intodiffpy:john-developmentfrom
Conversation
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
yes, this is in the right direction. Is that intended that you deleted all those other py files?
If this is a "cleaning" operation, then I would put that on a separate commit with nothing else on it that is clearly labelled so if we want any of those files back in the future we know we can get them from the commit before the cleaning commit.
| N, M = MM.shape | ||
|
|
||
| my_model = SNMFOptimizer(MM=MM, Y0=Y0, X0=X0, A0=A0) | ||
| my_model = SNMFOptimizer(source_matrix=MM, init_weights=Y0, init_comps=X0, init_stretch=A0) |
There was a problem hiding this comment.
yes, much more readable. But you still have some upper-cased variables there (MM, Y0 etc.). It is not clear what these are defaulting to. Should they not be positional variables and not optional variables? What happens in they are not all specified? Only make them optional if the function can be run successfully when one is not sepcified.
There was a problem hiding this comment.
Will close this to separate out the cleaning.
2 participants
This PR is not fully finished, but I wanted to get started with the review to make sure the style is acceptable. A few variables within functions still need to be renamed.