Skip to content

chore: deprecate abcABG and readStr method#164

Merged
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-method-lattice
Feb 24, 2026
Merged

chore: deprecate abcABG and readStr method#164
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-method-lattice

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review. Note that for readStr method since it is an inherited class method from Structure. We have done the deprecation for readStr there and so its test method. So we don't have to edit anything from test here.

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.99%. Comparing base (74683b6) to head (d09a89c).
⚠️ Report is 3 commits behind head on v3.4.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.4.0     #164   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          13       13           
  Lines        1988     1995    +7     
=======================================
+ Hits         1968     1975    +7     
  Misses         20       20           
Files with missing lines Coverage Δ
tests/test_lattice.py 99.57% <100.00%> (ø)
tests/test_p_discus.py 98.85% <100.00%> (ø)
tests/test_structure.py 99.80% <100.00%> (+<0.01%) ⬆️
tests/test_supercell.py 97.95% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit b453098 into diffpy:v3.4.0 Feb 24, 2026
6 checks passed
@sbillinge
Copy link
Contributor

@stevenhua0320 nicely done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants