Skip to content

chore: deprecate methods in GeneratorSite class#169

Merged
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-5
Feb 26, 2026
Merged

chore: deprecate methods in GeneratorSite class#169
sbillinge merged 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-5

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Are there new unittest tests or those are just cut and pasted from before. I am asking to make sure all new tests are pytest and not unittest

@stevenhua0320
Copy link
Contributor Author

There is no new test written here and all of them are pasted from before. I will follow the precedure that writing a new test if the method does not have a test before.

@sbillinge sbillinge merged commit 1395fc3 into diffpy:v3.4.0 Feb 26, 2026
4 checks passed
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (0d60a73) to head (a2e253a).
⚠️ Report is 3 commits behind head on v3.4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.4.0     #169      +/-   ##
==========================================
+ Coverage   99.03%   99.08%   +0.04%     
==========================================
  Files          13       13              
  Lines        2076     2183     +107     
==========================================
+ Hits         2056     2163     +107     
  Misses         20       20              
Files with missing lines Coverage Δ
tests/test_symmetryutilities.py 99.80% <100.00%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants