Skip to content

chore: deprecate SymmetryConstraints class method#170

Open
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-6
Open

chore: deprecate SymmetryConstraints class method#170
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:deprecate-symmetryutilities-6

Conversation

@stevenhua0320
Copy link
Contributor

@sbillinge ready to review.

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.10%. Comparing base (a2e253a) to head (40e30aa).
⚠️ Report is 1 commits behind head on v3.4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.4.0     #170      +/-   ##
==========================================
+ Coverage   99.08%   99.10%   +0.01%     
==========================================
  Files          13       13              
  Lines        2183     2226      +43     
==========================================
+ Hits         2163     2206      +43     
  Misses         20       20              
Files with missing lines Coverage Δ
tests/test_symmetryutilities.py 99.81% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls see comments

**Added:**

* Added ``_find_constraints`` method in ``SymmetryConstraints`` class
* Added ``pospar_symbols`` method in ``SymmetryConstraints`` class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pos_parm_symbols?

* Added ``_find_constraints`` method in ``SymmetryConstraints`` class
* Added ``pospar_symbols`` method in ``SymmetryConstraints`` class
* Added ``pospar_values`` method in ``SymmetryConstraints`` class
* Added ``upar_symbols`` method in ``SymmetryConstraints`` class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u_parm_symbols and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants