-
Notifications
You must be signed in to change notification settings - Fork 21
fix: add real data into example #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 520 520
=========================================
Hits 520 520 🚀 New features to boost your workflow:
|
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is that the example loads data from files
|
I reviewed the datasource in test files that ends in |
@cadenmyers13 for this we need diffraction datasets. Maybe not very large though if possible. so .chi or .iq or .fq |
|
@sbillinge I sent @stevenhua0320 a .chi file and a .fq file too. I think the .chi file is what we want. |
|
@stevenhua0320 Its been a while since I looked at this but I think the gist is to add the data to this repo so that users can grab it and run it for this example. try to fix the example and make it easy for users to run (add a link to the data or something like that). |
@sbillinge Ready to review