Skip to content

[WIP] Add credential selection feature with documentation update#426

Closed
rmlearney-digicatapult with Copilot wants to merge 1 commit into
feature/credential-selectionfrom
copilot/sub-pr-423
Closed

[WIP] Add credential selection feature with documentation update#426
rmlearney-digicatapult with Copilot wants to merge 1 commit into
feature/credential-selectionfrom
copilot/sub-pr-423

Conversation

Copilot AI commented Dec 11, 2025

Copy link
Copy Markdown

Review Comment Resolution Plan

  • Identify outdated vs still-valid comments
  • Fix test stubs not being verified in validation tests (lines 914-983)
  • Add predicate handling to maker-accept-proof-from-oem.ts script
  • Add validation for requestedAttributes in script before use
  • Document/address revealed:true hardcoding limitation in script
  • Review test data structure concerns (credentialInfo mocking)
  • Run tests to validate all changes
  • Reply to user comment with resolution summary

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants