Clarify review scope: ignore test script validation and credentialId logging#428
Closed
rmlearney-digicatapult with Copilot wants to merge 1 commit into
Closed
Clarify review scope: ignore test script validation and credentialId logging#428rmlearney-digicatapult with Copilot wants to merge 1 commit into
rmlearney-digicatapult with Copilot wants to merge 1 commit into
Conversation
9 tasks
Copilot
AI
changed the title
[WIP] Add credential selection feature and documentation
Clarify review scope: ignore test script validation and credentialId logging
Dec 12, 2025
Copilot stopped work on behalf of
rmlearney-digicatapult due to an error
December 12, 2025 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code changes made. User clarified that two automated review comments should be ignored:
maker-accept-proof-from-oem.ts): Validation concerns in example/test scripts are not blockingredactProofFormats): credentialId exposure in logs is acceptable for this deployment's security modelAll other review comments have been addressed and resolved in previous commits. The PR is ready for re-review with these exclusions noted.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.