Fix Support for m3u8 Playlist Files #914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the readonly array
supportedPlaylistExtensionswas intended to havem3uandm3u8(notflac). From what I can tell this array is used in the validation step for reading playlists in the Dopamine playlist folder. I came to this conclusion when I stumbled upon this line of code:dopamine/src/app/services/playlist/playlist-decoder.ts
Lines 14 to 19 in 0328c3a
Which is attempting to parse playlist files and accepts both the
m3uandm3u8extensions. It appears Dopamine supports UTF-8 encodings fine so I don't see why it would explicitly restrictm3u8files in the validation step, but please enlighten me if I am wrong.Without this change, Dopamine does not recognize
m3u8playlist files when placed in the playlist folder. I tested this change using Windows 11, node 20.19.5, npm 11.6.2 and confirmed the playlist appeared and played music from anm3u8playlist file.See #907