Skip to content

Playwright tests + accessibility #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Playwright tests + accessibility #322

wants to merge 13 commits into from

Conversation

stephenwf
Copy link
Member

No description provided.

Copy link

netlify bot commented Apr 11, 2025

Deploy Preview for manifest-editor-docs canceled.

Name Link
🔨 Latest commit 97c2d1f
🔍 Latest deploy log https://app.netlify.com/sites/manifest-editor-docs/deploys/67fff8df4f8d830008b695ac

Copy link

codesandbox-ci bot commented Apr 11, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

name: 'chromium',
use: {
...devices['Desktop Chrome'],
baseURL: 'http://localhost:3000',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no dev version of ME the tests will run against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is: https://manifest-editor.digirati.services/ but that's sort of like "production". I haven't hooked up the GitHub action yet, but I was thinking it could build and spin up the environment locally (no infrastructure dependencies). But I did see in the Portal tests that this is driven by an environment variable - maybe that could work here too.

Comment on lines +34 to +45
async waitForIdentifier() {
const manifestIdentifier = await this.page.getByRole("textbox", { name: "Identifier" });
expect(manifestIdentifier).toHaveValue(/https?:\/\/.*/);
this.#identifier = await manifestIdentifier.inputValue();
}

resolveContainer<
Type extends keyof typeof resources['supported'],
Field extends typeof resources['supported'][Type]['all'][number],
>(type: Type, field: Field) {
return this.page.locator(`[id='container_${this.identifier}_${type}_${field}']`);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All editors for the individual properties have a <div /> around them with a class name that's like:

class="container_https://example.org/manifest_Manifest_label"

Which would be the div containing something that edits the Manifests .label property, where the manifest id id is https://example.org/manifest.

Copy link

github-actions bot commented Apr 14, 2025

🚀 Deploying feature/test-prep with ⚡ Cloudflare Pages

Latest commit: 97c2d1f5e28d696cdc1ed702adc5e8c3e4700f0e
Status: ✅ Deploy successful
Preview URL: https://manifest-editor-preview.digirati.workers.dev
Branch Preview URL:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants