-
Notifications
You must be signed in to change notification settings - Fork 4
Playwright tests + accessibility #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for manifest-editor-docs canceled.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
name: 'chromium', | ||
use: { | ||
...devices['Desktop Chrome'], | ||
baseURL: 'http://localhost:3000', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no dev version of ME the tests will run against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is: https://manifest-editor.digirati.services/ but that's sort of like "production". I haven't hooked up the GitHub action yet, but I was thinking it could build and spin up the environment locally (no infrastructure dependencies). But I did see in the Portal tests that this is driven by an environment variable - maybe that could work here too.
async waitForIdentifier() { | ||
const manifestIdentifier = await this.page.getByRole("textbox", { name: "Identifier" }); | ||
expect(manifestIdentifier).toHaveValue(/https?:\/\/.*/); | ||
this.#identifier = await manifestIdentifier.inputValue(); | ||
} | ||
|
||
resolveContainer< | ||
Type extends keyof typeof resources['supported'], | ||
Field extends typeof resources['supported'][Type]['all'][number], | ||
>(type: Type, field: Field) { | ||
return this.page.locator(`[id='container_${this.identifier}_${type}_${field}']`); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All editors for the individual properties have a <div />
around them with a class name that's like:
class="container_https://example.org/manifest_Manifest_label"
Which would be the div containing something that edits the Manifests .label
property, where the manifest id id is https://example.org/manifest
.
🚀 Deploying feature/test-prep with ⚡ Cloudflare Pages
|
No description provided.